Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Screenshots doesn't account for DPI scaling anymore #4174

Closed
FatOrangutan opened this issue Mar 4, 2018 · 3 comments
Closed

Screenshots doesn't account for DPI scaling anymore #4174

FatOrangutan opened this issue Mar 4, 2018 · 3 comments
Assignees
Labels
defect firefox Something that has to ship in the add-on in Firefox [QA]:Other issue Valid issues logged by other people than the Softvision QA team. [QA]:Verified fixed Label for QA to mark verified fixed issues

Comments

@FatOrangutan
Copy link

FatOrangutan commented Mar 4, 2018

STR:

  1. Have dpi scale >100%
  2. Take a screenshot using either the drag / click method or the 'Save full page' button. Download it somewhere.

AR:

  1. screenshot turns out to be tinier than what you had on screen
  2. You now need to zoom in in your image viewer to make things readable but also blurry in the process

ER: it should be the same size, like it used to be until recently

The 'Save visible' button does still respect DPI. Issue seems to be with only drag, select and the 'Save full page' button.

I'm on Nightly 60.0a1 (2018-03-03), Screenshots v30; Windows 10.

@SoftVision-CosminMuntean

I have managed to reproduce this issue on the latest Nightly (60.0a1) build using Screenshots 30.0.0 version on Windows 7 x64 with a 150% DPI scale set. It seems that the issue is not reproducible on older Nightly builds with Screenshots 29.0.0 version. So think that the issue is a Screenshots regression and it was introduced on the latest (30.0.0) version.

I was able to reproduce the issue for a small downloaded image:

  • Screenshots 30.0.0 version (reproducible):

bad

  • Screenshots 29.0.0 version (not reproducible):

good

@ianb ianb added defect firefox Something that has to ship in the add-on in Firefox labels Mar 5, 2018
jaredhirsch added a commit that referenced this issue Mar 6, 2018
@jaredhirsch
Copy link
Member

This bug affects all downloaded or copied images.

Full page images have always been low-resolution, whether uploaded, downloaded, or copied. I'll file a followup bug to reconsider going full-resolution when downloading / copying.

@SoftVision-CosminMuntean
Copy link

SoftVision-CosminMuntean commented Mar 7, 2018

I have retested this issue using latest Screenshots (31.2.0) dev version and the issue is no longer reproducible. Tested on:
Windows 7 x64 with DPI scale set to 125%, 150%;
Windows 10 x64 with DPI scale set to 150%, 200% and 300% (on a 4k monitor);
Mac 10.12 with DPI scale set to 150%;

@SoftVision-CosminMuntean SoftVision-CosminMuntean added the [QA]:Verified fixed Label for QA to mark verified fixed issues label Mar 7, 2018
@SoftVision-CosminMuntean SoftVision-CosminMuntean added the [QA]:Other issue Valid issues logged by other people than the Softvision QA team. label Aug 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
defect firefox Something that has to ship in the add-on in Firefox [QA]:Other issue Valid issues logged by other people than the Softvision QA team. [QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Development

No branches or pull requests

4 participants