Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Give shot creation flow iframes the 'dialog' role #4671

Closed
jaredhirsch opened this issue Jul 18, 2018 · 1 comment
Closed

Give shot creation flow iframes the 'dialog' role #4671

jaredhirsch opened this issue Jul 18, 2018 · 1 comment
Assignees
@chenba
Labels
a11y firefox Something that has to ship in the add-on in Firefox good first issue
Milestone
Sprint 21 (64-2)

Comments

@jaredhirsch
Copy link
Member

Modal content is hard for a11y, as the a11y tree merges iframes into a single DOM, but giving our creation iframes role='dialog' will help screen readers understand that the creation frame is a modal on top of the existing page.
@johngruen johngruen added this to the Sprint 18 (63-2) milestone Jul 19, 2018
@ghost ghost modified the milestones: Sprint 18 (63-2), Sprint 19 (63-3) Aug 2, 2018
@punamdahiya
Copy link
Contributor

@6a68 this is related to screenshot creation frames. Should it be labelled firefox and fixed in webextension?

@chenba chenba added the firefox Something that has to ship in the add-on in Firefox label Aug 23, 2018
chenba added a commit to chenba/screenshots that referenced this issue Aug 31, 2018
@chenba
Add "dialog" role to addon ui frames. (mozilla-services#4671)
9476ab4
@chenba chenba mentioned this issue Aug 31, 2018
Merged
@chenba chenba self-assigned this Aug 31, 2018
jaredhirsch pushed a commit that referenced this issue Sep 11, 2018
@chenba @jaredhirsch
Add "dialog" role to addon ui frames. (#4671) (#4827)
84cb89c
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chenba chenba

Labels
a11y firefox Something that has to ship in the add-on in Firefox good first issue
Projects
None yet
Milestone
Sprint 21 (64-2)
Development

No branches or pull requests
5 participants
@clouserw @jaredhirsch @chenba @punamdahiya @johngruen