Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Put in a popup promotion for the editing tools #4724

Closed
ianb opened this issue Jul 31, 2018 · 16 comments
Closed

Put in a popup promotion for the editing tools #4724

ianb opened this issue Jul 31, 2018 · 16 comments
Assignees

Comments

@ianb
Copy link
Contributor

ianb commented Jul 31, 2018

Would be a simple popup dialog, that would show to people once (twice?) to tell them about this new/improved feature.

We could use the same React component we use to invite people to use Firefox. Or we can use the component used for the share dialog. We can use localStorage to track who has seen the popup before.

@clouserw is going to ask about text/copy. We should get some text in soon so we can get it to translators.

@ianb ianb added this to the Sprint 18 (63-2) milestone Jul 31, 2018
@punamdahiya punamdahiya self-assigned this Jul 31, 2018
@punamdahiya
Copy link
Contributor

@punamdahiya
Copy link
Contributor

@sevaan Need UX feedback on showing edit tool new features promotion dialog as per specs in comment above

screenshot_2018-07-31 firefox screenshots

@sevaan
Copy link
Collaborator

sevaan commented Aug 1, 2018

LGTM. Does mousing over it show the close x?

Also, re: the text, I think the title should be plural: New Edit Tools!

And a period or exclamation point after "support".

@clouserw
Copy link
Collaborator

clouserw commented Aug 1, 2018

Thanks. Michelle is pondering some new copy for us by this Friday.

@punamdahiya
Copy link
Contributor

Thanks @sevaan for feedback. For now promotion dialog closes when user clicks anywhere outside dialog (similar to share dialog seen on click of share icon) and doesn't have close x.

@jaredhirsch
Copy link
Member

Hmm. It seems like we should have some kind of caret pointing at the button we want people to click. The image there is just a box floating in space.

I think an 'x' to close the doorhanger makes more sense than clicking anywhere to dismiss it.

@jaredhirsch
Copy link
Member

Although I guess the share card doesn't have a caret. Maybe we could highlight the button and display the CTA just underneath it? Something like this:

screen shot 2018-08-01 at 2 29 44 pm

@punamdahiya
Copy link
Contributor

LGTM! 'Give it a try' can be a link as well and takes user to edit screen

@sevaan
Copy link
Collaborator

sevaan commented Aug 1, 2018

That's really great, @6a68!

@jaredhirsch
Copy link
Member

thanks! 🍻

@ghost ghost modified the milestones: Sprint 18 (63-2), Sprint 19 (63-3) Aug 6, 2018
punamdahiya added a commit to punamdahiya/screenshots that referenced this issue Aug 6, 2018
@clouserw
Copy link
Collaborator

clouserw commented Aug 7, 2018

From Michelle:

Here's my recommendation.
Take Note!
Updated editing tools let you crop, highlight, and even add text to your shot.

Am suggesting that you sell the whole feature and give a bit of emphasis to what's new. 1. New users may benefit from the whole story. 2. Existing users might not know or remember what's already there. 2. It's better to be specific about what it offers than just saying something is new - this gives people even more reason to explore the feature.

Which looks great to me.

punamdahiya added a commit to punamdahiya/screenshots that referenced this issue Aug 7, 2018
@punamdahiya
Copy link
Contributor

Screenshot with new copy from Michelle, updated PR with the changes
screenshot-promo-new-text

@punamdahiya
Copy link
Contributor

punamdahiya commented Aug 7, 2018

Screen shot with option to use text title 'Take Note!' in case it's preferred
screenshot-text-title

@johngruen
Copy link
Contributor

I like the second version... can we ditch the circle around the X?

@punamdahiya
Copy link
Contributor

Done
screenshot-promo-final

@johngruen
Copy link
Contributor

SHIPIT

punamdahiya added a commit to punamdahiya/screenshots that referenced this issue Aug 7, 2018
punamdahiya added a commit to punamdahiya/screenshots that referenced this issue Aug 8, 2018
punamdahiya added a commit to punamdahiya/screenshots that referenced this issue Aug 9, 2018
punamdahiya added a commit to punamdahiya/screenshots that referenced this issue Aug 9, 2018
punamdahiya added a commit to punamdahiya/screenshots that referenced this issue Aug 9, 2018
punamdahiya added a commit to punamdahiya/screenshots that referenced this issue Aug 9, 2018
punamdahiya added a commit to punamdahiya/screenshots that referenced this issue Aug 9, 2018
punamdahiya added a commit to punamdahiya/screenshots that referenced this issue Aug 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants