This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

[FxA] SignIn button on settings page triggers page not found #4896

Closed

punamdahiya opened this issue Sep 14, 2018 · 0 comments

Assignees

Contributor

punamdahiya commented Sep 14, 2018

STR

Click on settings in header and disconnect from FxA account
Access /settings page directly from URL
Click on SignIn

[Actual Result]
Shows page not found
[Expected]
Redirects to auth login page

With routes changed inside server.js, href for signin button needs to be updated to /api/fxa-oauth/login/ instead of existing /api/fxa-oauth/login

This was missed as we rarely access sign in from settings page

punamdahiya self-assigned this

chenba closed this as completed in

868295d

chenba added a commit that referenced this issue


          Merge pull request #4897 from punamdahiya/4896-settings-page-signin

1a2c4c0

Fixes #4896 - SignIn button link on settings page

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.