Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Turn off FxA marketing #5254

Closed
ianb opened this issue Dec 20, 2018 · 1 comment
Closed

Turn off FxA marketing #5254

ianb opened this issue Dec 20, 2018 · 1 comment
Assignees
@ianb
Milestone
Server messaging ...

Comments

@ianb
Copy link
Contributor

ianb commented Dec 20, 2018

This include #5253, but also the top bar promotion of FxA.
@ianb ianb added this to the Server messaging release milestone Dec 20, 2018
@jaredhirsch
Copy link
Member

This and #5253 should be really easy, just need to set all the promo-related shouldShow functions to return false in the PromotionStrategy. Sadly, that refactoring turned out to be incredibly prescient

@ianb ianb self-assigned this Jan 2, 2019
ianb added a commit that referenced this issue Jan 2, 2019
@ianb
Fix #5254 and fix #5253, remove FxA marketing
e1233a8 
This simply says to never show the promotions (but does not remove the promotion code).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ianb ianb

Labels
None yet
Projects
None yet
Milestone
Server messaging release
Development

No branches or pull requests
2 participants
@ianb @jaredhirsch