This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds : (important on Windows), \, <, and > to the blacklist. Followup in #3083
In test conditions, when the browser is started and stopped very quickly, sometimes we didn't shut down the WebExtension because it hadn't fully started. r=kmag (in https://bugzilla.mozilla.org/show_bug.cgi?id=1373614)
* Validate iframe URLs Remove unneeded iframe onload handlers * Put temporary clipboard TEXTAREA in an iframe With iframe URL validation
* set dimensions for icon and add to startup (#3136) * Address 10.6 review comments (bug 1381132) * Update version to 10.7.0 with changelog
* Do not re-wrap onResize when adding and removing the listener This caused the removeEventListener to silently fail, as the wrapped functions did not match (by identity) Fixes #3153 * Suppress error popups for all errors in resize handlers Errors still go to Sentry
Remove full-page & visible buttons and remove from onboarding
Don't localize removed buttons
Tweak button container CSS
This reverts commit 07a27a8.
jaredhirsch
approved these changes
Aug 4, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3273
This fully merges both the v10.4.0-export and v10.10.0 branches into master. The full screen commit gets merged and committed.