This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
empty docTitle value in JSON data #3348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nihakhanna
force-pushed
the
empty-doctitle
branch
from
dbac930 to
f9871b7
Compare
|
I thought this was a funny way to do it, but after thinking about it I like it – this way we can bring back the title, and effectively we're doing the private/public data approach we eventually want to get to, except for now treating everything like public. |
|
Now I don't know if I misread the commit or somehow it got applied in an odd way, but it's just removing the title entirely |
ianb
added a commit
that referenced
this pull request
Aug 16, 2017
jaredhirsch
pushed a commit
that referenced
this pull request
Aug 17, 2017
* Fix commit from #3348, keep title unless user has overwritten it * Fix #3249, create npm run test:server Make the tests no longer be executable, since the test runner runs * Add test for updating a shot with a new image Note: test succeeds (despite what I expected from #3290) * Fix flake8 errors * Fix #3207, put image sizes in images table * Fix #3318, add timing to all database queries Timing is logged when it goes over a configurable limit. Locations are logged based on caller filename/position * Add npm run test:server to CI tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Bug 1389706