Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Create empty robots.txt. Closes #3635 #3639

Merged
merged 5 commits into from
Oct 17, 2017
Merged

Create empty robots.txt. Closes #3635 #3639

merged 5 commits into from
Oct 17, 2017

Conversation

bn4t
Copy link
Contributor

@bn4t bn4t commented Oct 16, 2017

@bn4t bn4t changed the title Create empty robots.txt. Closes #3635 Create empty robots.txt. Closes https://github.com/mozilla-services/screenshots/issues/3635 Oct 16, 2017
@bn4t bn4t changed the title Create empty robots.txt. Closes https://github.com/mozilla-services/screenshots/issues/3635 Create empty robots.txt. Closes #3635 Oct 16, 2017
Copy link
Contributor

@ianb ianb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This creates /homepage/robots.txt, but clients will look for exactly /robots.txt

Looking at server.js we don't have any static file handler for the root. I think the easiest way to handle this will be to add another endpoint to server.js (i.e., app.get("/robots.txt", ...)) that serves up something empty.

@bn4t bn4t changed the title Create empty robots.txt. Closes #3635 [WIP] Create empty robots.txt. Closes #3635 Oct 17, 2017
@bn4t
Copy link
Contributor Author

bn4t commented Oct 17, 2017

I added it now to the server.js

Not sure if I've done it right. Please correct me if its wrong.

@bn4t bn4t changed the title [WIP] Create empty robots.txt. Closes #3635 Create empty robots.txt. Closes #3635 Oct 17, 2017
@bn4t bn4t changed the title Create empty robots.txt. Closes #3635 [Need help] Create empty robots.txt. Closes #3635 Oct 17, 2017
@bn4t bn4t changed the title [Need help] Create empty robots.txt. Closes #3635 Create empty robots.txt. Closes #3635 Oct 17, 2017
@ianb ianb merged commit c51912b into mozilla-services:master Oct 17, 2017
@ianb
Copy link
Contributor

ianb commented Oct 17, 2017

Looks good, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants