Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Fix #3826, sort all file lists in moz.build #3827

Merged
merged 1 commit into from
Nov 27, 2017
Merged

Conversation

ianb
Copy link
Contributor

@ianb ianb commented Nov 21, 2017

This seems to be a new ./mach build requirement

This seems to be a new ./mach build requirement
@jaredhirsch
Copy link
Member

Tell me more, I'm confused

@ianb
Copy link
Contributor Author

ianb commented Nov 27, 2017

@6a68: This is to fix an error I was getting consistently running mach build, per #3826: UnsortedError: An attempt was made to add an unsorted sequence to a list. The incoming list is unsorted starting at element 0. We expected "webextension/assertIsBlankDocument.js" but got "webextension/domainFromUrl.js"

@jaredhirsch
Copy link
Member

Huh. My exported branch has things properly alphabetized, which explains why I wasn't able to repro the error. I can repro if I undo the ordering.

@jaredhirsch jaredhirsch merged commit e4442eb into master Nov 27, 2017
@ianb
Copy link
Contributor Author

ianb commented Nov 27, 2017

Probably an upstream change to fix, and your export didn't have to override the moz.build files

@jaredhirsch jaredhirsch deleted the sort-mozbuild branch November 27, 2017 18:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants