Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Add "dialog" role to addon ui frames #4827

Merged
merged 1 commit into from
Sep 11, 2018
Merged

Add "dialog" role to addon ui frames #4827

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions addon/webextension/selector/ui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ this.ui = (function() { // eslint-disable-line no-unused-vars
this.element.style.display = "none";
this.element.style.setProperty("position", "absolute", "important");
this.element.style.setProperty("background-color", "transparent");
this.element.setAttribute("role", "dialog");
this.updateElementSize();
this.element.addEventListener("load", watchFunction(() => {
this.document = this.element.contentDocument;
Expand Down Expand Up @@ -278,6 +279,7 @@ this.ui = (function() { // eslint-disable-line no-unused-vars
this.element.style.setProperty("background-color", "transparent");
this.element.style.width = "100%";
this.element.style.height = "100%";
this.element.setAttribute("role", "dialog");
this.element.addEventListener("load", watchFunction(() => {
this.document = this.element.contentDocument;
assertIsBlankDocument(this.document);
Expand Down Expand Up @@ -390,6 +392,7 @@ this.ui = (function() { // eslint-disable-line no-unused-vars
this.element.style.setProperty("background-color", "transparent");
this.element.style.height = "100%";
this.element.style.width = "100%";
this.element.setAttribute("role", "dialog");
this.element.onload = watchFunction(() => {
this.document = this.element.contentDocument;
// eslint-disable-next-line no-unsanitized/property
Expand Down