Fixes #5002 - UI fixes in non-Firefox #5071
Conversation
|
Fixes #5072 |
| // Depending on the user agent computed styles | ||
| // line-height can have value as normal | ||
| if (line_height.toLowerCase() === "normal") { | ||
| line_height = 1.1 * FONT_SIZE; |
There was a problem hiding this comment.
Using value 1.1 (approximate default 1.2) to compute line-height for the fonts used in TextTool
There was a problem hiding this comment.
Hmm. This special case doesn't cover other weird stuff, like ems or percentages, that might be set as a user agent's default. Can we just set the line-height in the CSS directly?
|
Fixes #5002 |
|
Fixes #5106 |
There was a problem hiding this comment.
Not a huge deal, but it's better to have separate PRs for small fixes, because some bugs are fixed here, and some still aren't.
OK, bad news first:
Seems related to #5002 item 1, the 404 page layout in this branch is pretty broken on safari and chrome:
I'm also seeing a stray backtick in the shots page on safari:
Stuff that's fixed:
-
[FxA] Screenshots website UI fixes on non-Firefox browsers #5002 item 3 / [Annotations] The added text is not visible on the shot if is added from Chrome, Opera or Edge #5106, text edits are saved in both safari and chrome, working great (I haven't tried opera or edge, though)
-
"Delete" button is wrongly enlarged on "Shots" page on non-Firefox browsers #5072 / [FxA] Screenshots website UI fixes on non-Firefox browsers #5002 item 1, huge delete button on the shot page, looks fixed:
|
Page not found issue got fixed in master with #5034, I will rebase PR on top of latest master, that should fix the issue |
punamdahiya
force-pushed
the
5002_Non-Firefox-UI-Fixes
branch
from
079443d to
9d551bf
Compare
|
@6a68 Updated PR with master that should fix page not found, thanks for catching the stray tick updated to remove that in shot index view. |
| // Depending on the user agent computed styles | ||
| // line-height can have value as normal | ||
| if (line_height.toLowerCase() === "normal") { | ||
| line_height = 1.1 * FONT_SIZE; |
There was a problem hiding this comment.
Hmm. This special case doesn't cover other weird stuff, like ems or percentages, that might be set as a user agent's default. Can we just set the line-height in the CSS directly?
|
@6a68 AFAIK It’s hard to determine line-height for a font-size and set in CSS as it varies across platform. Also, as per w3c input default line-height in all user agents should be normal. |
|
Heh, thanks for schooling me. I wasn't thinking that you wrote the text tool, and have bumped into all these edge cases already. |
No description provided.