This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Fixes #5052 - Messaging on settings page #5156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredhirsch
changed the title
|
This can't land until we have product approval on the strings |
johngruen
reviewed
Nov 15, 2018
locales/en-US/server.ftl
Outdated
| @@ -280,6 +280,7 @@ settingsDescription = You can sign in with Firefox Accounts to sync all your scr | |||
| settingsPageSubHeader = Sync & Accounts | |||
| settingsClosePreferences = | |||
| .title = Close preferences | |||
| settingsFxaDisconnectDescription = If you disconnect with Firefox Accounts your synced screenshots will remain in your account but you will need to signin to regain access to them. | |||
There was a problem hiding this comment.
If you sign out, you will need to sign in again to regain access to your screenshots.
johngruen
reviewed
Nov 15, 2018
locales/en-US/server.ftl
Outdated
| @@ -280,6 +280,7 @@ settingsDescription = You can sign in with Firefox Accounts to sync all your scr | |||
| settingsPageSubHeader = Sync & Accounts | |||
There was a problem hiding this comment.
This should not be Sync and Accounts...
It should just be Firefox Account
There was a problem hiding this comment.
We should not use the word Sync here, Sync is a specific service name and we should not conflate the two
punamdahiya
force-pushed
the
5052-settings
branch
from
21898f1 to
9103f90
Compare
|
Updated with product feedback |
punamdahiya
changed the title
|
@flodolo Including to review localization changes. Thanks! |
flodolo
approved these changes
Nov 16, 2018
jaredhirsch
approved these changes
Nov 16, 2018
|
LGTM, needs a rebase though |
punamdahiya
force-pushed
the
5052-settings
branch
from
9103f90 to
0e71f3b
Compare
|
Landed after rebasing with latest master |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.