Bug 1932405 - Improve signatures involving checked pointers #6812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielesvelto
force-pushed
the
bug-1932405-checked-unsafe-ptr
branch
from
9bb697b to
5c4d7d9
Compare
willkg
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
app@socorro:/app$ ./mybin/test_signature_change.sh 'mozilla::CheckCheckedUnsafePtrs<T>::Check' mozilla::CheckingPolicyAccess::NotifyCheckFailure 'mozilla::detail::SupportCheckedUnsafePtrImpl<T>' 'mozilla::SupportsCheckedUnsafePtr<T>::~SupportsCheckedUnsafePtr' mozilla::CrashOnDanglingCheckedUnsafePtr::NotifyCheckFailure
Working on 'mozilla::CheckCheckedUnsafePtrs<T>::Check' ...
No crashids found for "mozilla::CheckCheckedUnsafePtrs<T>::Check" this month.
Working on 'mozilla::CheckingPolicyAccess::NotifyCheckFailure' ...
No crashids found for "mozilla::CheckingPolicyAccess::NotifyCheckFailure" this month.
Working on 'mozilla::detail::SupportCheckedUnsafePtrImpl<T>' ...
No crashids found for "mozilla::detail::SupportCheckedUnsafePtrImpl<T>" this month.
Working on 'mozilla::SupportsCheckedUnsafePtr<T>::~SupportsCheckedUnsafePtr' ...
No crashids found for "mozilla::SupportsCheckedUnsafePtr<T>::~SupportsCheckedUnsafePtr" this month.
Working on 'mozilla::CrashOnDanglingCheckedUnsafePtr::NotifyCheckFailure' ...
Crash id: af721926-e629-4364-aa76-1203b0241103
Original: mozilla::CrashOnDanglingCheckedUnsafePtr::NotifyCheckFailure
New: mozilla::CrashOnDanglingCheckedUnsafePtr::NotifyCheckFailure | mozilla::dom::fs::data::FileSystemDataManager::~FileSystemDataManager
Same?: False
Crash id: 9c69cae9-ec18-43fd-9e08-c69950241106
Original: mozilla::CrashOnDanglingCheckedUnsafePtr::NotifyCheckFailure
New: mozilla::CrashOnDanglingCheckedUnsafePtr::NotifyCheckFailure | mozilla::dom::fs::data::FileSystemDataManager::~FileSystemDataManager
Same?: False
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.