Bug 1943919 - Add TppRaiseInvalidParameter to the prefix list #6875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want to add this function to the irrelevant list because it conveys an important bit of information (that we're crashing because an invalid paramter has been passed to a Windows system function), but we still want to skip over it in order to be able to tell different crashes apart.
gabrielesvelto
force-pushed
the
bug-1943919-skip-over-tppraiseinvalidparameter
branch
from
fa3caa7 to
575e8ed
Compare
gabrielesvelto
changed the title
|
I tested this with 10 recent crash reports with Does this look correct? |
|
Yes, that represents the bulk of the crashes under that signature, but there's more and I've already preemptively filed the bugs for the other signatures. |
smarnach
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to add this function to the irrelevant list because it conveys an important bit of information (that we're crashing because an invalid paramter has been passed to a Windows system function), but we still want to skip over it in order to be able to tell different crashes apart.