feat: add collection id/name caching at the pool level #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and a couple more db calls that utilize it Issue #18
bbangert
approved these changes
Sep 21, 2018
philbooth
reviewed
Sep 24, 2018
| @@ -65,7 +65,7 @@ impl Server { | |||
| let state = ServerState { | |||
| // TODO: replace MockDb with a real implementation | |||
| db: Box::new(MockDb::new()), | |||
| secrets: secrets.clone(), | |||
| secrets: Arc::clone(&secrets), | |||
There was a problem hiding this comment.
Purely for my own education, I'm curious about this change.
Was secrets.clone() not doing what I thought it was before, or is this about code style, or is there some other underlying difference between the two?
There was a problem hiding this comment.
This became the idiomatic way of calling smart pointer methods last year rust-lang/rust#42137 -- intention was to clarify you're calling the typically cheap smart pointer clone vs a potentially heavier inner clone operation
philbooth
approved these changes
Sep 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and a couple more db calls that utilize it
Issue #18