-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reload weights after plateau #3245
Conversation
No Taskcluster jobs started for this pull requestThe `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request. |
@DanBmh Thanks, can you elaborate a little bit? My mind is kind of somewhere else, so I'm unsure I get the point here. |
Currently training looks like this:
The old approach did still work well but I think we can make it even better by reloading the weights from the best_dev checkpoint. |
Not ready yet! |
Working again:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'd like Reuben's opinion.
# Reload checkpoint that we use the best_dev weights again | ||
load_or_init_graph_for_training(session, allow_drop_layers=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep this function unchanged and add a new explicitly load_best_checkpoint
function, we don't want this call to load last silently for example.
Re-opened as #3261 to run tests. |
Tests #3245 Reload weights after plateau
Merged in #3261 |
Reload checkpoint weights after reaching a plateau that we use the best_dev weights again