fix: fix build_and_test job in CircleCI #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rob--W
force-pushed
the
xpi-deployment-2
branch
from
5f4e2c2 to
3375edd
Compare
One of build_and_test's commands is `npm run xpi`, which eventually runs `web-ext build`. Because the `WEB_EXT_API_SECRET` and `WEB_EXT_API_KEY` environment variables are currently set in CircleCI's secret environment variables, the build breaks because `web-ext build` fails to run when these are set: mozilla/web-ext#793 As a work-around, unset those env vars before running `web-ext build`.
Rob--W
force-pushed
the
xpi-deployment-2
branch
from
3375edd to
a1e0391
Compare
jbuck
approved these changes
Aug 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.