-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add retries to the APIClient session #96
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a test for this too?
I was attempting to, but there are no docs on running the tests and out of the box it runs tests against a server that no longer exists. If I were to add tests I would need some guidance from the FxA team. |
thanks @robhudson ! |
Any chance to publish a new release to PyPI with this change? |
I started #99 however I don't have write access to mozilla/PyFxA to merge it anymore. |
Yes I guess it makes sense to add you 😀 |
We are using zest.releaser to make the release. Once #99 is merged, you can use |
I think you have an invite for write access. It also said we have limited seats, so, let's see if it works. |
Yes I received it, do you have access to circle ci by any chance to fix it's access too? |
I did the release, you can remove my permission to the github repository til next time, you now have the permission on the pypi project too. |
Thanks. I'll leave you on it unless we run out of seats. I fixed circleci's access, but it looks like the tests are pretty broken (out of date dependencies, at least on the older python). Anyway, one step closer. Thanks for the release @Natim |
Potential fix for the connection errors.
See mozmeao/basket#1187