Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retries to the APIClient session #96

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

robhudson
Copy link
Member

Potential fix for the connection errors.

See mozmeao/basket#1187

Copy link
Collaborator

@Natim Natim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a test for this too?

@robhudson
Copy link
Member Author

I was attempting to, but there are no docs on running the tests and out of the box it runs tests against a server that no longer exists. If I were to add tests I would need some guidance from the FxA team.

@clouserw clouserw merged commit 96d4dde into mozilla:main Feb 28, 2024
@clouserw
Copy link
Member

thanks @robhudson !

@robhudson
Copy link
Member Author

Any chance to publish a new release to PyPI with this change?

@clouserw
Copy link
Member

I think @Natim is the only still active maintainer. If this is the only diff I'd be fine with pushing a 0.7.8 out.

@Natim would you add me (clouserw) as a maintainer as well please?

@Natim
Copy link
Collaborator

Natim commented Mar 14, 2024

I started #99 however I don't have write access to mozilla/PyFxA to merge it anymore.

@Natim
Copy link
Collaborator

Natim commented Mar 14, 2024

Yes I guess it makes sense to add you 😀

@Natim
Copy link
Collaborator

Natim commented Mar 14, 2024

We are using zest.releaser to make the release. Once #99 is merged, you can use release and postrelease to generate the v0.7.8 Github tag and set back the main branch into development mode.

@clouserw
Copy link
Member

I think you have an invite for write access. It also said we have limited seats, so, let's see if it works.

@Natim
Copy link
Collaborator

Natim commented Mar 15, 2024

Yes I received it, do you have access to circle ci by any chance to fix it's access too?

https://app.circleci.com/pipelines/github/mozilla/PyFxA/12/workflows/46c7895a-bb4e-4672-8e6d-151fa1a4b8f8/jobs/23

@Natim
Copy link
Collaborator

Natim commented Mar 15, 2024

I did the release, you can remove my permission to the github repository til next time, you now have the permission on the pypi project too.

@clouserw
Copy link
Member

Thanks. I'll leave you on it unless we run out of seats.

I fixed circleci's access, but it looks like the tests are pretty broken (out of date dependencies, at least on the older python). Anyway, one step closer. Thanks for the release @Natim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants