Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experiment with the useEffect hook #246

Closed
kumar303 opened this issue Feb 21, 2019 · 3 comments
Closed

Experiment with the useEffect hook #246

kumar303 opened this issue Feb 21, 2019 · 3 comments
Labels
component:code_quality priority:p3 state:stale

Comments

@kumar303
Copy link
Contributor

A good place to start on hooks is to consider porting some components to useEffect. A lot of bugs I've seen on addons-frontend were related to all the if statement logic we needed in constructor() and componentDidUpdate() to know when to load data. I think useEffect will simplify that kind of logic and we already have some components in addons-code-manager like App which are relying on this logic.
@kumar303 kumar303 mentioned this issue Feb 21, 2019
Merged
@willdurand willdurand mentioned this issue Apr 11, 2019
Merged
@kumar303
Copy link
Contributor Author

See #363

@stale
Copy link

stale bot commented Nov 25, 2019

This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions.

@stale stale bot added the state:stale label Nov 25, 2019
@stale
Copy link

stale bot commented May 24, 2020

This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions.

@stale stale bot added the state:stale label May 24, 2020
@stale stale bot closed this as completed Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:code_quality priority:p3 state:stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kumar303