Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port Compare page to the useEffect hook #363

Open
kumar303 opened this issue Mar 8, 2019 · 3 comments
Open

Port Compare page to the useEffect hook #363

kumar303 opened this issue Mar 8, 2019 · 3 comments
Labels
component:code_quality priority:p3 state:blocked_by_upstream

Comments

@kumar303
Copy link
Contributor

kumar303 commented Mar 8, 2019 •
edited by data-sync-user
Loading

The Compare page grew some gnarly load/update logic in #342

This component can be ported to useEffect which will simplify the loading logic and let us delete a bunch of the tests.

┆Issue is synchronized with this Jira Task
@willdurand
Copy link
Member

This could be done together with #111.

@willdurand willdurand mentioned this issue Mar 15, 2019
Merged
@willdurand
Copy link
Member

I guess this is blocked by upstream for now because Enzyme (shallow) does not support Hooks: enzymejs/enzyme#2011.

@kumar303
Copy link
Contributor Author

If we only want useEffect, we might only need to wait on facebook/react#15275

@kumar303 kumar303 mentioned this issue May 29, 2019
Closed
@kumar303 kumar303 mentioned this issue Jul 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:code_quality priority:p3 state:blocked_by_upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kumar303 @willdurand