-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow current version id to be false #969
Allow current version id to be false #969
Conversation
Codecov Report
@@ Coverage Diff @@
## master #969 +/- ##
==========================================
+ Coverage 98.8% 98.81% +<.01%
==========================================
Files 55 55
Lines 1761 1772 +11
Branches 449 454 +5
==========================================
+ Hits 1740 1751 +11
Misses 15 15
Partials 6 6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for jumping into this one. It's looking really good but I noticed this issue:
- Go to http://localhost:3000/
- Click on browse a page
- Press the back button
- Click on browse a page again
The title disappears from the browse page. If you'd like any tips on where to look for solving it, just let me know.
9e7b293
to
5b757e1
Compare
@kumar303 I updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, @mirefly. It's getting close, I just have a few change requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good, it just needs some additional test cases. If you get stuck setting up the state for those tests, let me know.
Here's a good way to develop it: temporarily set the if statement back to !currentVersionId
and watch your new test fail. Fixing the if statement should pass the test.
Thanks @kumar303 I added two test cases. |
@mirefly whoops, it looks like something landed on master that gave you a conflict. Can you merge this branch with master (or rebase on master) and resolve the conflict? |
e9222a8
to
2ccc112
Compare
Now it works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 👍 Thanks!
Fixes #955 @kumar303