Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move InstallButton into core #930

Merged
merged 2 commits into from
Aug 18, 2016
Merged

Move InstallButton into core #930

merged 2 commits into from
Aug 18, 2016

Conversation

kumar303
Copy link
Contributor

@kumar303 kumar303 mentioned this pull request Aug 16, 2016
Closed
@kumar303
Copy link
Contributor Author

@muffinresearch r? I wasn't sure if all these constants should live in core or not.

muffinresearch
muffinresearch reviewed Aug 17, 2016
View reviewed changes
src/core/constants.js
export const API_THEME_TYPE = 'persona';
export const EXTENSION_TYPE = 'extension';
export const THEME_TYPE = 'theme';
// These types are not used.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably remove these.

@muffinresearch
Copy link
Contributor

r+ looks good.

It'll be worth testing disco pane on -dev just to make sure everything's still happy. See https://wiki.mozilla.org/Add-ons/Projects/DiscoveryImprovements#Testing for instructions.

@kumar303
Copy link
Contributor Author

@muffinresearch thanks for that link. I set extensions.webservice.discoverURL to http://127.0.0.1:3000/%LOCALE%/firefox/discovery/pane/%VERSION%/%OS%/%COMPATIBILITY_MODE% on Nightly but I still get:

_mozAddonManager is undefined

Are there additional steps for testing against my local server?

@muffinresearch
Copy link
Contributor

muffinresearch commented Aug 18, 2016 •
edited
Loading

You'll only be able to test against -dev / stage with those instructions. Anything else requires spoofing hosts. Which you can do with charles. I can probably export a working config to get you started tomorrow if you need it.

@kumar303
Copy link
Contributor Author

we're going to land this on dev and see how it goes!

@kumar303 kumar303 merged commit 087f2d2 into mozilla:master Aug 18, 2016
@kumar303 kumar303 deleted the move-install branch August 18, 2016 16:26
@kumar303
Copy link
Contributor Author

I tested it on dev, seemed to work!

@olizilla olizilla mentioned this pull request Feb 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@muffinresearch muffinresearch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move InstallButton into core
2 participants
@kumar303 @muffinresearch