Skip to content

Commit

Permalink
Remove localization in this project (#5520)
Browse files Browse the repository at this point in the history
  • Loading branch information
willdurand authored Dec 12, 2024
1 parent 2bf19a8 commit b40366c
Show file tree
Hide file tree
Showing 73 changed files with 36 additions and 69,002 deletions.
13 changes: 0 additions & 13 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -145,18 +145,6 @@ jobs:
- run: npm run webext-test-functional
- run: npm run smoke-test-eslint-version-conflicts

lint-locales:
working_directory: ~/addons-linter
docker:
- image: cimg/python:3.11.3
steps:
- checkout
- run:
name: lint locale files
command: |
pip install dennis
dennis-cmd lint --errorsonly locale/
release-tag:
<<: *defaults
steps:
Expand All @@ -180,7 +168,6 @@ workflows:
only: /.*/
- test-next
- test-alternate
- lint-locales
- release-tag:
requires:
- test
Expand Down
10 changes: 0 additions & 10 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -189,16 +189,6 @@ We use [pino](https://github.com/pinojs/pino) for logging:

We use [Prettier](https://prettier.io/) to automatically format our JavaScript code and stop all the on-going debates over styles. As a developer, you have to run it (with `npm run prettier-dev`) before submitting a Pull Request.

### L10n extraction

The localization process is very similar to [how we do it for addons-frontend](https://addons-frontend.readthedocs.io/en/latest/i18n/#updating-locales): locales are always updated on the `master` branch, any PR that changes or introduces new localized strings should be merged on `master` first.

In order to update the locales (when new localized strings are added to the codebase), run the following script from the `master` branch. This script automates _all_ the steps described in the addons-frontend docs, without any confirmation step.

```
./scripts/run-l10n-extraction
```

## Architecture

In a nutshell the way the linter works is to take an add-on package, extract the metadata from the xpi (zip) format and then process the files it finds through various content scanners.
Expand Down
4 changes: 0 additions & 4 deletions bin/addons-linter
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
#!/usr/bin/env node
/* eslint-disable global-require */
const path = require('path');

const absoluteAppRoot = path.resolve(path.join(__dirname, '..'));
global.localesRoot = path.join(absoluteAppRoot, 'dist', 'locale');
global.nodeRequire = require;

(async () => {
Expand Down
Loading

0 comments on commit b40366c

Please sign in to comment.