Prevent error when strict_min_version is not a string value (#3913)

mozilla · Sep 14, 2021 · e5e5b55 · e5e5b55
1 parent b0850dd
commit e5e5b55
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/utils.js b/src/utils.js
@@ -398,7 +398,8 @@ export function firefoxStrictMinVersion(manifestJson) {
   if (
     manifestJson.applications &&
     manifestJson.applications.gecko &&
-    manifestJson.applications.gecko.strict_min_version
+    manifestJson.applications.gecko.strict_min_version &&
+    typeof manifestJson.applications.gecko.strict_min_version === 'string'
   ) {
     return parseInt(
       manifestJson.applications.gecko.strict_min_version.split('.')[0],

diff --git a/tests/unit/test.utils.js b/tests/unit/test.utils.js
@@ -512,6 +512,14 @@ describe('firefoxStrictMinVersion', () => {
       })
     ).toEqual(60);
   });
+
+  it('should return null when value is not a string', () => {
+    expect(
+      firefoxStrictMinVersion({
+        applications: { gecko: { strict_min_version: 12.3 } },
+      })
+    ).toEqual(null);
+  });
 });
 
 describe('basicCompatVersionComparison', () => {