Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting support for all icons in manifest.json #2677

Closed
amccausl opened this issue Jul 9, 2019 · 1 comment · Fixed by #2678
Closed

Linting support for all icons in manifest.json #2677

amccausl opened this issue Jul 9, 2019 · 1 comment · Fixed by #2678
Assignees
@amccausl
Labels
priority:p3 state:verified_fixed
Milestone
2019.07.25

Comments

@amccausl
Copy link
Contributor

amccausl commented Jul 9, 2019 •
edited
Loading

Describe the problem and steps to reproduce it:

Icon validation only validates the root icons property of the manifest.

$ printf '{ "browser_action": { "default_icon": {"32": "nonexistingfile.png"}}, "name": "name here", "version": "1", "manifest_version": 2 }\n' > manifest.json
$ web-ext lint
Validation Summary:

errors          0              
notices         0              
warnings        0

What happened?

No error

What did you expect to happen?

Expected to get error when icon defined in the manifest is missing for any of the valid icons. Includes:

browser_action.default_icon.*
browser_action.theme_icons.*
page_action.default_icon.*
sidebar_action.default_icon.*

Anything else we should know?

Related to: mozilla/web-ext#1653
@amccausl amccausl mentioned this issue Jul 9, 2019
Closed
@mozilla mozilla deleted a comment Jul 9, 2019
amccausl added a commit to amccausl/addons-linter that referenced this issue Jul 10, 2019
@amccausl
Add linting for all icons in manifest (mozilla#2677)
3b5bd84
amccausl added a commit to amccausl/addons-linter that referenced this issue Jul 10, 2019
@amccausl
Add linting for all icons in manifest (mozilla#2677)
85a4a31
@amccausl amccausl mentioned this issue Jul 10, 2019
Merged
5 tasks
amccausl added a commit to amccausl/addons-linter that referenced this issue Jul 10, 2019
@amccausl
Add linting for all icons in manifest (mozilla#2677)
2ff41f0
EnTeQuAk added a commit that referenced this issue Jul 11, 2019
@EnTeQuAk
Add linting for all icons in manifest (#2677) (#2678)
c587c7a 
Add linting for all icons in manifest (#2677)
@EnTeQuAk EnTeQuAk added this to the 2019.07.18 milestone Jul 11, 2019
@EnTeQuAk EnTeQuAk modified the milestones: 2019.07.18, 2019.07.25 Jul 18, 2019
@vcarciu
Copy link

vcarciu commented Jul 24, 2019

Verified as fixed for

browser_action.default_icon.*
browser_action.theme_icons.*
page_action.default_icon.*
sidebar_action.default_icon.*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amccausl amccausl

Labels
priority:p3 state:verified_fixed
Projects
None yet
Milestone
2019.07.25
Development

Successfully merging a pull request may close this issue.

Add linting for all icons in manifest (#2677) amccausl/addons-linter
4 participants
@EnTeQuAk @amccausl @wagnerand @vcarciu