Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files with a flagged extension are not considered binary files #5258

Closed
willdurand opened this issue Apr 17, 2024 · 1 comment · Fixed by #5262 or #5263
Closed

Files with a flagged extension are not considered binary files #5258

willdurand opened this issue Apr 17, 2024 · 1 comment · Fixed by #5262 or #5263

Comments

@willdurand
Copy link
Member

willdurand commented Apr 17, 2024

STR:

  1. lint an add-on with a large .exe file (> 4MB)

Expected:

Maybe a message about the file being flagged due to its file extension.

Actual:

An error is emitted about the file being too big, and not a binary file. This is not correct.

┆Issue is synchronized with this Jira Task

@ioanarusiczki
Copy link

I tried on -dev with linter 6.26.0

nowondev

Before there was the error

before on stage

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment