Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not mark special files as large #5262

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Do not mark special files as large #5262

merged 1 commit into from
Apr 22, 2024

Conversation

willdurand
Copy link
Member

@willdurand willdurand commented Apr 22, 2024

Fixes #5258 (kinda)

┆Issue is synchronized with this Jira Task

@willdurand willdurand requested a review from rpl April 22, 2024 12:52
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.75%. Comparing base (d601dd5) to head (93db69a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5262   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files          51       51           
  Lines        2884     2887    +3     
  Branches      882      885    +3     
=======================================
+ Hits         2848     2851    +3     
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rpl rpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable to me too.

@willdurand willdurand merged commit ebbe997 into master Apr 22, 2024
5 checks passed
@willdurand willdurand deleted the fix-binary-large branch April 22, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Files with a flagged extension are not considered binary files
2 participants