Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Imported Firefox 93.0b7 API schema #3919

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

rpl
Copy link
Member

@rpl rpl commented Sep 17, 2021

This PR includes the following new schema updates imported from Firefox 93.0b7:

These changes to the imported JSONSchema data does not require any other additional changes to the addons-linter, especially given that the addons-linter eslint rules are not really using this data (none of the API methods parameters are validated using the schema data).

@rpl rpl requested a review from Rob--W September 17, 2021 16:43
@rpl
Copy link
Member Author

rpl commented Sep 17, 2021

@Rob--W the CI failure on the test-alternate job is a known nodejs issue (nodejs/node#40030), totally unrelated with the changes in this PR.

@willdurand
Copy link
Member

@Rob--W the CI failure on the test-alternate job is a known nodejs issue (nodejs/node#40030), totally unrelated with the changes in this PR.

Looks like this upstream issue has been fixed.

@willdurand willdurand merged commit 9934ca6 into mozilla:master Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants