Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude hidden URLs from syncing and views #1715

Merged
merged 1 commit into from
Sep 11, 2019

Conversation

linabutler
Copy link
Member

@linabutler linabutler commented Sep 3, 2019

Hidden URLs are useful for storing redirect chains, and may be useful
for manual searching or awesomebar matches. However, the history
record format doesn't currently include the referrer or hidden state,
so we exclude them entirely to match Desktop, and to avoid cluttering
other devices with redirect sources.

We also filter them out in visit queries, so that Fenix doesn't have
to make changes for mozilla-mobile/fenix#3526. In a future release,
we can either return them and have Fenix filter them out in some
views, or add a flag to include or exclude them.

See #1492.

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • cargo test --all produces no test failures
    • cargo clippy --all --all-targets --all-features runs without emitting any warnings
    • cargo fmt does not produce any changes to the code
    • ./gradlew ktlint detekt runs without emitting any warnings
    • swiftformat --swiftversion 4 megazords components/*/ios && swiftlint runs without emitting any warnings or producing changes
    • Note: For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGES_UNRELEASED.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

Hidden URLs are useful for storing redirect chains, and may be useful
for manual searching or awesomebar matches. However, the history
record format doesn't currently include the referrer or hidden state,
so we exclude them entirely to match Desktop, and to avoid cluttering
other devices with redirect sources.

We also filter them out in visit queries, so that Fenix doesn't have
to make changes for mozilla-mobile/fenix#3526. In a future release,
we can either return them and have Fenix filter them out in some
views, or add a flag to include or exclude them.

See #1492.
@linabutler linabutler marked this pull request as ready for review September 11, 2019 23:38
@linabutler linabutler merged commit f7565b2 into master Sep 11, 2019
@linabutler linabutler deleted the dont-sync-or-show-hidden branch September 11, 2019 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants