Exclude hidden URLs from syncing and views #1715
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hidden URLs are useful for storing redirect chains, and may be useful
for manual searching or awesomebar matches. However, the history
record format doesn't currently include the referrer or hidden state,
so we exclude them entirely to match Desktop, and to avoid cluttering
other devices with redirect sources.
We also filter them out in visit queries, so that Fenix doesn't have
to make changes for mozilla-mobile/fenix#3526. In a future release,
we can either return them and have Fenix filter them out in some
views, or add a flag to include or exclude them.
See #1492.
Pull Request checklist
cargo test --all
produces no test failurescargo clippy --all --all-targets --all-features
runs without emitting any warningscargo fmt
does not produce any changes to the code./gradlew ktlint detekt
runs without emitting any warningsswiftformat --swiftversion 4 megazords components/*/ios && swiftlint
runs without emitting any warnings or producing changes[ci full]
to the PR title.