Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust 2018 #455

Merged
merged 9 commits into from
Dec 12, 2018
Merged

Rust 2018 #455

merged 9 commits into from
Dec 12, 2018

Conversation

eoger
Copy link
Contributor

@eoger eoger commented Dec 11, 2018

Convert all our crates to the rust 2018 edition

@eoger eoger requested a review from thomcc December 11, 2018 19:38
thomcc
thomcc approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@thomcc thomcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The use serde_derive::* seems a bit odd, but I guess that's how it's done now. The way log import works ideal either but I don't care that much. In the future I'll probably just do log::blah! assuming that still works.

components/places/examples/sync_history.rs Outdated Show resolved Hide resolved
components/support/ffi/Cargo.toml Outdated Show resolved Hide resolved
@eoger eoger merged commit cbb33dc into master Dec 12, 2018
@eoger eoger deleted the rust-2018 branch December 12, 2018 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncalexan ncalexan ncalexan left review comments

@thomcc thomcc thomcc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eoger @thomcc @ncalexan