text fixes

mozilla · Sep 11, 2024 · 12793a2 · 12793a2
1 parent 968a137
commit 12793a2
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/bedrock/contentful/api.py b/bedrock/contentful/api.py
@@ -294,9 +294,10 @@ def render(self, node):
         if url.netloc != "www.mozilla.org":
             # add security measures
             rel = ' rel="external noopener"'
-            # add analytics
-            cta_text = _make_plain_text(node)
-            data_cta = f'  data-cta-text="{cta_text}"'
+
+        # add analytics
+        cta_text = _make_plain_text(node)
+        data_cta = f' data-cta-text="{cta_text}"'
 
         return f'<a href="{urlunparse(url)}{ref}"{data_cta}{rel}>{self._render_content(node)}</a>'
 

diff --git a/bedrock/newsletter/tests/test_views.py b/bedrock/newsletter/tests/test_views.py
@@ -190,7 +190,7 @@ def test_shows_form_single(self):
         doc = pq(resp.content)
         self.assertTrue(doc("#newsletter-form"))
         self.assertTrue(doc('input[value="mozilla-foundation"]'))
-        self.assertEqual(doc("#newsletter-submit")[0].attrib["data-cta-type"], "Newsletter-mozilla-foundation")
+        self.assertEqual(doc("#newsletter-submit")[0].attrib["data-cta-text"], "Newsletter Sign Up")
 
     @patch("bedrock.newsletter.views.basket")
     def test_returns_success(self, basket_mock):

diff --git a/bedrock/products/tests/test_helper_misc.py b/bedrock/products/tests/test_helper_misc.py
@@ -1666,7 +1666,7 @@ def test_vpn_product_referral_link(self):
         expected = (
             '<a href="/en-US/products/vpn/#pricing" class="mzp-c-button js-fxa-product-referral-link '
             'mzp-t-product mzp-t-secondary mzp-t-md" data-referral-id="navigation" '
-            'data-cta-text="Get Mozilla VPN" >Get Mozilla VPN</a>'
+            'data-cta-text="Get Mozilla VPN">Get Mozilla VPN</a>'
         )
         self.assertEqual(markup, expected)
 
@@ -1682,7 +1682,7 @@ def test_vpn_product_referral_link_pricing_page(self):
         expected = (
             '<a href="/en-US/products/vpn/pricing/" class="mzp-c-button js-fxa-product-referral-link '
             'mzp-t-product mzp-t-secondary mzp-t-md" data-referral-id="navigation" '
-            'data-cta-text="Get Mozilla VPN" >Get Mozilla VPN</a>'
+            'data-cta-text="Get Mozilla VPN" data-cta-type="vpn">Get Mozilla VPN</a>'
         )
         self.assertEqual(markup, expected)
 
@@ -1699,6 +1699,6 @@ def test_vpn_product_referral_link_optional_params(self):
         expected = (
             '<a href="/en-US/products/vpn/pricing/?coupon=cyber20" class="mzp-c-button js-fxa-product-referral-link '
             'mzp-t-product mzp-t-secondary mzp-t-md" data-referral-id="navigation" '
-            'data-cta-text="Get Mozilla VPN" >Get Mozilla VPN</a>'
+            'data-cta-text="Get Mozilla VPN" data-cta-type="vpn">Get Mozilla VPN</a>'
         )
         self.assertEqual(markup, expected)