Skip to content

Commit

Permalink
review fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
@stephaniehobson
stephaniehobson committed Oct 7, 2024
1 parent 17e6aab commit c2a48e4
Show file tree
Hide file tree
Showing 11 changed files with 36 additions and 65 deletions.
12 changes: 6 additions & 6 deletions bedrock/base/templates/includes/protocol/navigation/menus-refresh/about-us.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,42 +13,42 @@
<ul class="mzp-l-content">
<li>
<section class="c-menu-item">
<a class="c-menu-item-link" href="{{ url('mozorg.about.index') }}" data-link-text="About us" data-link-position="topnav - about" data-link-group="about-us">
<a class="c-menu-item-link" href="{{ url('mozorg.about.index') }}" data-link-text="About us" data-link-position="topnav - about">
<h4 class="c-menu-item-title">{{ ftl('navigation-refresh-about-us') }}</h4>
</a>
</section>
</li>
<li>
<section class="c-menu-item">
<a class="c-menu-item-link" href="{{ url('mozorg.about.manifesto') }}" data-link-text="Mozilla manifesto" data-link-position="topnav - about" data-link-group="about-us">
<a class="c-menu-item-link" href="{{ url('mozorg.about.manifesto') }}" data-link-text="Mozilla manifesto" data-link-position="topnav - about">
<h4 class="c-menu-item-title">{{ ftl('navigation-refresh-mozilla-manifesto') }}</h4>
</a>
</section>
</li>
<li>
<section class="c-menu-item">
<a class="c-menu-item-link" href="https://foundation.mozilla.org/?{{ utm_params }}" data-link-text="Mozilla Foundation" data-link-position="topnav - about" data-link-group="about-us">
<a class="c-menu-item-link" href="https://foundation.mozilla.org/?{{ utm_params }}" data-link-text="Mozilla Foundation" data-link-position="topnav - about">
<h4 class="c-menu-item-title">{{ ftl('navigation-refresh-mozilla-foundation') }}</h4>
</a>
</section>
</li>
<li>
<section class="c-menu-item">
<a class="c-menu-item-link" href="{{ url('mozorg.contribute') }}" data-link-text="Get Involved" data-link-position="topnav - about" data-link-group="about-us">
<a class="c-menu-item-link" href="{{ url('mozorg.contribute') }}" data-link-text="Get Involved" data-link-position="topnav - about">
<h4 class="c-menu-item-title">{{ ftl('navigation-refresh-get-involved') }}</h4>
</a>
</section>
</li>
<li>
<section class="c-menu-item">
<a class="c-menu-item-link" href="https://future.mozilla.org/?{{ utm_params }}" data-link-text="Mozilla Innovation Projects" data-link-position="topnav - about" data-link-group="about-us">
<a class="c-menu-item-link" href="https://future.mozilla.org/?{{ utm_params }}" data-link-text="Mozilla Innovation Projects" data-link-position="topnav - about">
<h4 class="c-menu-item-title">{{ ftl('navigation-refresh-innovation-projects') }}</h4>
</a>
</section>
</li>
<li>
<section class="c-menu-item">
<a class="c-menu-item-link" href="https://blog.mozilla.org/?{{ utm_params }}" data-link-text="Blog" data-link-position="topnav - about" data-link-group="about-us">
<a class="c-menu-item-link" href="https://blog.mozilla.org/?{{ utm_params }}" data-link-text="Blog" data-link-position="topnav - about">
<h4 class="c-menu-item-title">{{ ftl('navigation-refresh-blog') }}</h4>
</a>
</section>
Expand Down
10 changes: 5 additions & 5 deletions bedrock/base/templates/includes/protocol/navigation/menus-refresh/firefox.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,39 +18,39 @@
<ul class="mzp-l-content">
<li>
<section class="c-menu-item mzp-has-icon">
<a class="c-menu-item-link" href="{{ url('firefox.new') }}" data-link-text="Firefox Desktop Browser" data-link-position="topnav - firefox" data-link-group="firefox" data-testid="navigation-menu-link-firefox-desktop">
<a class="c-menu-item-link" href="{{ url('firefox.new') }}" data-link-text="Firefox Desktop Browser" data-link-position="topnav - firefox" data-testid="navigation-menu-link-firefox-desktop">
<img loading="lazy" src="{{ static('protocol/img/logos/firefox/browser/logo.svg') }}" class="c-menu-item-icon" width="32" height="32" alt="">
<h4 class="c-menu-item-title">{{ ftl('navigation-refresh-firefox-for-desktop') }}</h4>
</a>
</section>
</li>
<li>
<section class="c-menu-item mzp-has-icon">
<a class="c-menu-item-link" href="{{ url('firefox.browsers.mobile.ios') }}" data-link-text="Firefox for iOS" data-link-position="topnav - firefox" data-link-group="firefox">
<a class="c-menu-item-link" href="{{ url('firefox.browsers.mobile.ios') }}" data-link-text="Firefox for iOS" data-link-position="topnav - firefox">
<img loading="lazy" src="{{ static('protocol/img/logos/firefox/browser/logo.svg') }}" class="c-menu-item-icon" width="32" height="32" alt="">
<h4 class="c-menu-item-title">{{ ftl('navigation-refresh-firefox-for-ios') }}</h4>
</a>
</section>
</li>
<li>
<section class="c-menu-item mzp-has-icon">
<a class="c-menu-item-link" href="{{ url('firefox.browsers.mobile.android') }}" data-link-text="Firefox for Android" data-link-position="topnav - firefox" data-link-group="firefox">
<a class="c-menu-item-link" href="{{ url('firefox.browsers.mobile.android') }}" data-link-text="Firefox for Android" data-link-position="topnav - firefox">
<img loading="lazy" src="{{ static('protocol/img/logos/firefox/browser/logo.svg') }}" class="c-menu-item-icon" width="32" height="32" alt="">
<h4 class="c-menu-item-title">{{ ftl('navigation-refresh-firefox-for-android') }}</h4>
</a>
</section>
</li>
<li>
<section class="c-menu-item mzp-has-icon">
<a class="c-menu-item-link" href="{{ url('firefox.browsers.mobile.focus') }}" data-link-text="Firefox Focus" data-link-position="topnav - firefox" data-link-group="firefox">
<a class="c-menu-item-link" href="{{ url('firefox.browsers.mobile.focus') }}" data-link-text="Firefox Focus" data-link-position="topnav - firefox">
<img loading="lazy" src="{{ static('protocol/img/logos/firefox/browser/focus/logo.svg') }}" class="c-menu-item-icon" width="32" height="32" alt="">
<h4 class="c-menu-item-title">{{ ftl('navigation-refresh-firefox-focus') }}</h4>
</a>
</section>
</li>
<li>
<section class="c-menu-item mzp-has-icon">
<a class="c-menu-item-link" href="https://blog.mozilla.org/firefox/?{{ utm_params }}" data-link-text="Firefox Blog" data-link-position="topnav - firefox" data-link-group="firefox">
<a class="c-menu-item-link" href="https://blog.mozilla.org/firefox/?{{ utm_params }}" data-link-text="Firefox Blog" data-link-position="topnav - firefox">
<svg class="c-menu-item-icon" xmlns="http://www.w3.org/2000/svg" width="32" height="32" viewBox="0 0 32 32"><path fill="#42435a" d="M21.1 7.5c-.2-.2-.2-.5 0-.7l.5-.5c.8-.8 2.1-.8 2.9 0l1.2 1.2c.8.8.8 2.1 0 2.9l-.5.5c-.2.2-.5.2-.7 0l-3.4-3.4zm2.3 4.5c.2.2.2.5 0 .7L12.7 23.4c-.2.2-.4.3-.6.4l-5.7 2.4c-.3.1-.6 0-.7-.3-.1-.1-.1-.3 0-.4L8.1 20c.1-.2.3-.5.4-.6L19.2 8.6c.2-.2.5-.2.7 0l3.5 3.4zM11.5 22.7l-3.9 1.7 1.7-3.9c0-.1.1-.2.2-.2l2.3 2.3c-.1 0-.2.1-.3.1z"></path></svg>
<h4 class="c-menu-item-title">{{ ftl('navigation-refresh-firefox-blog') }}</h4>
</a>
Expand Down
16 changes: 8 additions & 8 deletions bedrock/base/templates/includes/protocol/navigation/menus-refresh/products.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,63 +15,63 @@
<ul class="mzp-l-content">
<li>
<section class="c-menu-item mzp-has-icon">
<a class="c-menu-item-link" href="{{ url('products.vpn.landing') }}" data-link-text="Mozilla VPN" data-link-position="topnav - products" data-link-group="products">
<a class="c-menu-item-link" href="{{ url('products.vpn.landing') }}" data-link-text="Mozilla VPN" data-link-position="topnav - products">
<img loading="lazy" src="{{ static('protocol/img/logos/mozilla/vpn/logo.svg') }}" class="c-menu-item-icon" width="32" height="32" alt="">
<h4 class="c-menu-item-title">{{ ftl('navigation-refresh-mozilla-vpn') }}</h4>
</a>
</section>
</li>
<li>
<section class="c-menu-item mzp-has-icon">
<a class="c-menu-item-link" href="https://monitor.mozilla.org/?{{ utm_params }}" data-link-text="Mozilla Monitor" data-link-position="topnav - products" data-link-group="products">
<a class="c-menu-item-link" href="https://monitor.mozilla.org/?{{ utm_params }}" data-link-text="Mozilla Monitor" data-link-position="topnav - products">
<img loading="lazy" src="{{ static('protocol/img/logos/firefox/monitor/logo.svg') }}" class="c-menu-item-icon" width="32" height="32" alt="">
<h4 class="c-menu-item-title">{{ ftl('navigation-refresh-mozilla-monitor') }}</h4>
</a>
</section>
</li>
<li>
<section class="c-menu-item mzp-has-icon">
<a class="c-menu-item-link" href="https://relay.firefox.com/?{{ utm_params }}" data-link-text="Firefox Relay" data-link-position="topnav - products" data-link-group="products">
<a class="c-menu-item-link" href="https://relay.firefox.com/?{{ utm_params }}" data-link-text="Firefox Relay" data-link-position="topnav - products">
<img loading="lazy" src="{{ static('protocol/img/logos/firefox/relay/logo.svg') }}" class="c-menu-item-icon" width="32" height="32" alt="">
<h4 class="c-menu-item-title">{{ ftl('navigation-refresh-firefox-relay') }}</h4>
</a>
</section>
</li>
<li>
<section class="c-menu-item mzp-has-icon">
<a class="c-menu-item-link" href="https://getpocket.com/firefox_learnmore/?{{ utm_params }}" data-link-text="Pocket" data-link-position="topnav - products" data-link-group="products">
<a class="c-menu-item-link" href="https://getpocket.com/firefox_learnmore/?{{ utm_params }}" data-link-text="Pocket" data-link-position="topnav - products">
<img loading="lazy" src="{{ static('protocol/img/logos/pocket/logo.svg') }}" class="c-menu-item-icon" width="32" height="32" alt="">
<h4 class="c-menu-item-title">{{ ftl('navigation-refresh-pocket') }}</h4>
</a>
</section>
</li>
<li>
<section class="c-menu-item mzp-has-icon">
<a class="c-menu-item-link" href="https://developer.mozilla.org/plus?{{ utm_params }}" data-link-text="MDN Plus" data-link-position="topnav - products" data-link-group="products">
<a class="c-menu-item-link" href="https://developer.mozilla.org/plus?{{ utm_params }}" data-link-text="MDN Plus" data-link-position="topnav - products">
<img loading="lazy" src="{{ static('img/nav/icons/icon-mdn-plus.svg') }}" class="c-menu-item-icon" width="32" height="32" alt="">
<h4 class="c-menu-item-title">{{ ftl('navigation-refresh-mdn-plus') }}</h4>
</a>
</section>
</li>
<li>
<section class="c-menu-item mzp-has-icon">
<a class="c-menu-item-link" href="https://fakespot.com/?{{ utm_params }}" data-link-text="Fakespot" data-link-position="topnav - products" data-link-group="projects">
<a class="c-menu-item-link" href="https://fakespot.com/?{{ utm_params }}" data-link-text="Fakespot" data-link-position="topnav - products">
<img loading="lazy" src="{{ static('img/logos/fakespot/logo-blue.svg') }}" class="c-menu-item-icon" width="32" height="32" alt="">
<h4 class="c-menu-item-title">{{ ftl('navigation-refresh-fakespot') }}</h4>
</a>
</section>
</li>
<li>
<section class="c-menu-item mzp-has-icon">
<a class="c-menu-item-link" href="https://www.thunderbird.net/{{ referrals }}" data-link-text="Thunderbird" data-link-position="topnav - products" data-link-group="products">
<a class="c-menu-item-link" href="https://www.thunderbird.net/{{ referrals }}" data-link-text="Thunderbird" data-link-position="topnav - products">
<img loading="lazy" src="{{ static('img/logos/thunderbird/logo-thunderbird.svg') }}" class="c-menu-item-icon" width="32" height="32" alt="">
<h4 class="c-menu-item-title">{{ ftl('navigation-refresh-thunderbird') }}</h4>
</a>
</section>
</li>
</ul>
<p class="c-menu-category-link">
<a href="{{ url('products.landing') }}" data-link-text="Go to all browsers and products" data-link-position="topnav - products" data-link-group="firefox">
<a href="{{ url('products.landing') }}" data-link-text="Go to all browsers and products" data-link-position="topnav - products">
{{ ftl('navigation-refresh-all-products') }}
<svg fill="none" height="24" width="24" xmlns="http://www.w3.org/2000/svg"><clipPath id="a"><path d="M0 0h24v24H0z"/></clipPath><g clip-path="url(#a)"><path d="M10.45 10.789v1.806H5V10.79zm8.55.903L10.45 4.5v6.289h1.806v-2.41l3.938 3.313-3.938 3.312v-2.409H10.45v6.289z" fill="#fff"/></g></svg>
</a>
Expand Down
2 changes: 1 addition & 1 deletion bedrock/firefox/templates/firefox/all/download.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ <h2 {% if not (product and platform and locale) %} class="c-step-name t-step-dis
{% if platform.startswith("linux") %}
{# Linux preamble #}
<p class="c-linux-debian"><br>
{{ ftl('download-button-using-debian', attrs='href="https://support.mozilla.org/kb/install-firefox-linux#w_install-firefox-deb-package-for-debian-based-distributions" rel="external noopener" data-cta-type="link" data-cta-text="You can set up our APT repository instead"'|safe) }}
{{ ftl('download-button-using-debian', attrs='href="https://support.mozilla.org/kb/install-firefox-linux#w_install-firefox-deb-package-for-debian-based-distributions" rel="external noopener" data-cta-text="You can set up our APT repository instead"'|safe) }}
</p>
{% endif %}
{% if product.slug.startswith("desktop") %}
Expand Down
2 changes: 1 addition & 1 deletion bedrock/firefox/templates/firefox/all/mobile.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
{% endif %}

{% if product.slug.startswith('mobile') %}
<p><a href="{{ url('firefox.browsers.mobile.get-app') }}" class="c-get-app" data-cta-type="link" data-cta-text="Send a link">{{ ftl('firefox-all-product-send-link') }}</a></p>
<p><a href="{{ url('firefox.browsers.mobile.get-app') }}" class="c-get-app" data-cta-text="Send a link">{{ ftl('firefox-all-product-send-link') }}</a></p>
{% endif %}

</div>
6 changes: 3 additions & 3 deletions bedrock/firefox/templates/firefox/built-for-you/landing.de.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
<h1 class="mzp-u-title-lg">Gemacht mit Blick auf deine Sicherheit</h1>
<p class="c-hero-tagline">Keine Kompromisse, bei den Dingen, die dir wichtig sind: Sicherheit, Produktivität und die Freiheit, so zu sein, wie du willst – mit Firefox.</p>
<div class="cta-is-firefox">
<a id="set-as-default-button" href="{{ url('firefox.set-as-default.thanks') }}" class="mzp-c-button" data-cta-text="Mach Firefox zu deinem Standardbrowser" data-cta-type="button" data-cta-position="page-hero">
<a id="set-as-default-button" href="{{ url('firefox.set-as-default.thanks') }}" class="mzp-c-button" data-cta-text="Mach Firefox zu deinem Standardbrowser" data-cta-position="page-hero">
Mach Firefox zu deinem Standardbrowser
</a>
</div>
Expand Down Expand Up @@ -167,7 +167,7 @@ <h3 class="c-feature-title">
<h2 class="mzp-u-title-md">Rase durchs Web</h2>
<p>Dank Firefox vergisst du, was Lag bedeutet. Unser Browser war nie schneller und lädt jetzt YouTube-Videos schneller als jemals zuvor.</p>
<div class="cta-is-firefox">
<a id="set-as-default-button" href="{{ url('firefox.set-as-default.thanks') }}" class="mzp-c-button" data-cta-text="Mach Firefox zu deinem Standardbrowser" data-cta-type="button" data-cta-position="speed-section">
<a id="set-as-default-button" href="{{ url('firefox.set-as-default.thanks') }}" class="mzp-c-button" data-cta-text="Mach Firefox zu deinem Standardbrowser" data-cta-position="speed-section">
Mach Firefox zu deinem Standardbrowser
</a>
</div>
Expand All @@ -188,7 +188,7 @@ <h2 class="mzp-u-title-md">Rase durchs Web</h2>
<img class="mzp-c-callout-media" src="{{ static('img/firefox/built-for-you/choose.svg') }}" width="184" height="116" alt="">
<h2 class="mzp-c-callout-title mzp-u-title-md">Wähle einen Browser, der für dich gemacht ist</h2>
<div class="cta-is-firefox">
<a id="set-as-default-button" href="{{ url('firefox.set-as-default.thanks') }}" class="mzp-c-button" data-cta-text="Mach Firefox zu deinem Standardbrowser" data-cta-type="button" data-cta-position="page-footer">
<a id="set-as-default-button" href="{{ url('firefox.set-as-default.thanks') }}" class="mzp-c-button" data-cta-text="Mach Firefox zu deinem Standardbrowser" data-cta-position="page-footer">
Mach Firefox zu deinem Standardbrowser
</a>
</div>
Expand Down
6 changes: 3 additions & 3 deletions bedrock/firefox/templates/firefox/built-for-you/landing.fr.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
<h1 class="mzp-u-title-lg">Conçu pour ta sécurité</h1>
<p class="c-hero-tagline">Ne fais plus de compromis sur ce qui compte pour toi : être en sécurité, plus productif et libre d’être qui tu veux, avec Firefox.</p>
<div class="cta-is-firefox">
<a id="set-as-default-button" href="{{ url('firefox.set-as-default.thanks') }}" class="mzp-c-button" data-cta-text="Faites de Firefox votre navigateur par défaut" data-cta-type="button" data-cta-position="page-hero">
<a id="set-as-default-button" href="{{ url('firefox.set-as-default.thanks') }}" class="mzp-c-button" data-cta-text="Faites de Firefox votre navigateur par défaut" data-cta-position="page-hero">
Faites de Firefox votre navigateur par défaut
</a>
</div>
Expand Down Expand Up @@ -167,7 +167,7 @@ <h3 class="c-feature-title">
<h2 class="mzp-u-title-md">Accélère ton expérience web</h2>
<p>Avec Firefox, fini le temps des pages lentes à charger. Notre navigateur n’a jamais été aussi rapide ; les vidéos Youtube se chargent en un éclair.</p>
<div class="cta-is-firefox">
<a href="{{ url('firefox.set-as-default.thanks') }}" class="mzp-c-button" data-cta-text="Faites de Firefox votre navigateur par défaut" data-cta-type="button" data-cta-position="speed-section">
<a href="{{ url('firefox.set-as-default.thanks') }}" class="mzp-c-button" data-cta-text="Faites de Firefox votre navigateur par défaut" data-cta-position="speed-section">
Faites de Firefox votre navigateur par défaut
</a>
</div>
Expand All @@ -188,7 +188,7 @@ <h2 class="mzp-u-title-md">Accélère ton expérience web</h2>
<img class="mzp-c-callout-media" src="{{ static('img/firefox/built-for-you/choose.svg') }}" width="184" height="116" alt="">
<h2 class="mzp-c-callout-title mzp-u-title-md">Choisis un navigateur pensé pour toi</h2>
<div class="cta-is-firefox">
<a href="{{ url('firefox.set-as-default.thanks') }}" class="mzp-c-button" data-cta-text="Faites de Firefox votre navigateur par défaut" data-cta-type="button" data-cta-position="page-footer">
<a href="{{ url('firefox.set-as-default.thanks') }}" class="mzp-c-button" data-cta-text="Faites de Firefox votre navigateur par défaut" data-cta-position="page-footer">
Faites de Firefox votre navigateur par défaut
</a>
</div>
Expand Down
Loading

0 comments on commit c2a48e4

Please sign in to comment.