Skip to content

Commit

Permalink
Remove Glean custom page view ping (Fixes #13652)
Browse files Browse the repository at this point in the history
  • Loading branch information
alexgibson committed Sep 19, 2023
1 parent ed1fce8 commit dfcc192
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 21 deletions.
3 changes: 1 addition & 2 deletions docs/attribution/0001-analytics.rst
Original file line number Diff line number Diff line change
Expand Up @@ -382,8 +382,7 @@ Defining metrics and pings
All of the data we send to the Glean pipeline is defined in
:abbr:`YAML (Yet Another Markup Language)` schema files in the ``./glean/``
project root directory. The ``metrics.yaml`` file defines all the different
metrics types and events we record, and the ``pings.yaml`` file defines
any custom pings we use to send collections of individual metrics.
metrics types and events we record.

.. Note::

Expand Down
14 changes: 0 additions & 14 deletions glean/pings.yaml

This file was deleted.

3 changes: 0 additions & 3 deletions media/js/glean/page.es6.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

import * as page from '../libs/glean/page.js';
import Utils from './utils.es6';
import { pageView as pageViewPing } from '../libs/glean/pings.js';

const defaultParams = {
utm_source: '',
Expand Down Expand Up @@ -50,8 +49,6 @@ function initPageView() {
}

page.hit.record();

pageViewPing.submit();
}

function pageEvent(obj) {
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@
"prettier-check": "prettier --check .",
"stylelint-fix": "./node_modules/.bin/stylelint \"media/css/**/*.{css,scss}\" --fix",
"format": "npm run prettier && npm run stylelint-fix",
"glean-lint": "glean glinter glean/metrics.yaml glean/pings.yaml",
"glean": "npm run glean-lint && glean translate glean/metrics.yaml glean/pings.yaml -f javascript -o media/js/libs/glean/"
"glean-lint": "glean glinter glean/metrics.yaml",
"glean": "npm run glean-lint && glean translate glean/metrics.yaml -f javascript -o media/js/libs/glean/"
},
"browserslist": [
"defaults",
Expand Down

0 comments on commit dfcc192

Please sign in to comment.