Skip to content

Commit

Permalink
Update footer newsletter text and signups (fixes #15585) (#15703)
Browse files Browse the repository at this point in the history
* Update footer newsletter text and signups (fixes #15585)

Removes initial newsletter string, it cannot be used as a fallback
because the new newsletter sign-up includes more than just Firefox
content.

* Add fallback string from newsletter_form.ftl
  • Loading branch information
maureenlholland authored Dec 11, 2024
1 parent 71c2512 commit f47a17d
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 21 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@
<div class="moz24-newsletter-wrapper">
<div class="moz24-newsletter-info">
<img loading="lazy" class="moz24-newsletter-image" src="{{ static('img/logos/m24/symbol-white.svg') }}" alt="" width="40" height="48">
<p>{{ ftl('footer-refresh-get-the-best') }}</p>
<p>{{ ftl('footer-refresh-discover-mozilla-products', fallback='newsletter-form-we-will-only-send-v2') }}</p>
</div>

<div class="moz24-newsletter">
{{ email_newsletter_form(
newsletters='mozilla-and-you',
newsletters='mozilla-foundation, mozilla-and-you',
title=None
)}}
</div>
Expand Down
2 changes: 1 addition & 1 deletion l10n/en/footer-refresh.ftl
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at https://mozilla.org/MPL/2.0/.

footer-refresh-get-the-best = Get the best { -brand-name-firefox } tips, tricks and updates. We promise to keep your email private and secure — just the best of { -brand-name-firefox } sent straight to your inbox.
footer-refresh-discover-mozilla-products =Discover { -brand-name-mozilla } products and initiatives. We promise to keep your email private and secure — no sharing, no selling, just great updates.
footer-refresh-leadership = Leadership
footer-refresh-advertise = Advertise with { -brand-name-mozilla }
footer-refresh-firefox-release-notes = { -brand-name-firefox } Release Notes
Expand Down
38 changes: 20 additions & 18 deletions media/css/m24/components/footer-newsletter.scss
Original file line number Diff line number Diff line change
Expand Up @@ -195,9 +195,26 @@ $max-footer-content-width: $content-max;

@media #{$mq-lg} {
display: grid;
grid-template-columns: 1fr 1fr;
grid-template-rows: 30px 45px 75px;
grid-template-columns: [full-width-start] 1fr 1fr [full-width-end];
column-gap: $spacer-lg;

> * {
grid-column: full-width;
}

// country input
label:first-of-type,
p:first-of-type {
grid-column-start: 1;
grid-column-end: 2;
}

// lang input
label:nth-of-type(2),
p:nth-of-type(2) {
grid-column-start: 2;
grid-column-end: 3;
}
}

p {
Expand All @@ -209,25 +226,10 @@ $max-footer-content-width: $content-max;

@media #{$mq-lg} {
display: inline-grid;

&:first-of-type {
grid-column-start: 1;
grid-column-end: 2;
}

&:nth-of-type(2) {
grid-column-start: 2;
grid-column-end: 3;
}
}

&:has(> label.mzp-u-inline) {
margin: $spacer-lg 0 $spacer-md;

@media #{$mq-lg} {
grid-column-start: 1;
grid-column-end: 3;
}
margin-bottom: $spacer-lg;

input {
margin: 0;
Expand Down

0 comments on commit f47a17d

Please sign in to comment.