Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all instances of data-cta-type="button" or "link" #14901

Closed
Tracked by #14749
stephaniehobson opened this issue Jul 29, 2024 · 2 comments
Closed
Tracked by #14749

Remove all instances of data-cta-type="button" or "link" #14901

stephaniehobson opened this issue Jul 29, 2024 · 2 comments
Assignees
@stephaniehobson
Labels
Analytics 📈

Comments

@stephaniehobson
Copy link
Contributor

stephaniehobson commented Jul 29, 2024 •
edited
Loading

In GA4 the only valid use of cta-type is when linking to mozilla accounts (fka fxa): fxa-sync, fxa-monitor. Remove inappropriate uses.
@stephaniehobson stephaniehobson mentioned this issue Jul 29, 2024
Open
@stephaniehobson
Copy link
Contributor Author

See also #14902

@stephaniehobson stephaniehobson mentioned this issue Jul 29, 2024
Open
@stephaniehobson stephaniehobson changed the title Remove all instances of data-cta-type Remove all instances of data-cta-type="button" or "link" Jul 29, 2024
@stephaniehobson stephaniehobson self-assigned this Aug 2, 2024
@stephaniehobson
Copy link
Contributor Author

Fixed in #14910

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephaniehobson stephaniehobson

Labels
Analytics 📈
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stephaniehobson