Update docs and code to remove GA3 references and match GA4 reality #14910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephaniehobson
force-pushed
the
ua-docs
branch
3 times, most recently
from
d8ede47 to
242f61b
Compare
stephaniehobson
commented
Jul 30, 2024
stephaniehobson
commented
Jul 30, 2024
| @@ -19,7 +19,7 @@ | |||
| class_name='mzp-t-product mzp-t-secondary mzp-t-md', | |||
| optional_attributes= { | |||
| 'data-cta-text' : 'Get Mozilla VPN', | |||
| 'data-cta-type' : 'button', | |||
| 'data-cta-type' : 'vpn', | |||
There was a problem hiding this comment.
This links to a page on WMO and so should not have the fxa- prefix other cta-types have (true for all occurrences of vpn_product_referral_link)
stephaniehobson
commented
Jul 30, 2024
stephaniehobson
force-pushed
the
ua-docs
branch
3 times, most recently
from
2f33c6a to
0149529
Compare
stephaniehobson
added
Needs Review
|
Note to self: add docs about stub attribution needing data-download-version |
9 tasks
stephaniehobson
force-pushed
the
ua-docs
branch
2 times, most recently
from
437863c to
9ef2ff3
Compare
stephaniehobson
changed the title
stephaniehobson
force-pushed
the
ua-docs
branch
6 times, most recently
from
4562671 to
34d1a09
Compare
stephaniehobson
commented
Sep 4, 2024
stephaniehobson
force-pushed
the
ua-docs
branch
from
12793a2 to
e6306eb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14910 +/- ##
=======================================
Coverage 78.42% 78.42%
=======================================
Files 162 162
Lines 8344 8344
=======================================
Hits 6544 6544
Misses 1800 1800 ☔ View full report in Codecov by Sentry. |
|
Rebased! |
stephaniehobson
force-pushed
the
ua-docs
branch
5 times, most recently
from
beffdaf to
6b002f5
Compare
|
Rebased again! |
reemhamz
requested changes
Sep 24, 2024
There was a problem hiding this comment.
Whewwwww, this was a big one.
💡 Note that this needs another rebase
Good job working so diligently on this! I left some important questions and suggestions, however I'm also still finding instances of data-cta-type="b utton", data-cta-type="link", and data-link-group in the code in the code that should be addressed:
bedrock/base/templates/includes/protocol/navigation/menus-refresh/about-us.html
Outdated
Show resolved
Hide resolved
bedrock/base/templates/includes/protocol/navigation/menus-refresh/firefox.html
Outdated
Show resolved
Hide resolved
bedrock/base/templates/includes/protocol/navigation/menus-refresh/products.html
Outdated
Show resolved
Hide resolved
bedrock/firefox/templates/firefox/features/includes/subnav.html
Outdated
Show resolved
Hide resolved
Update analytics documentation to remove UA and edit the code to make it match the GA4 docs. - Re-write analytics documentation intro - Remove: UA documentation - Remove: UA dataLayer pushes - Remove: data-link-group (migrate into data-link-position where appropriate) - Remove: data-cta-type="button" - Remove: data-cta-type="link" - data-cta and data-link should not be used on the same attribute
stephaniehobson
force-pushed
the
ua-docs
branch
2 times, most recently
from
87ac590 to
c2a48e4
Compare
stephaniehobson
force-pushed
the
ua-docs
branch
from
c2a48e4 to
8e5ccd4
Compare
|
Ready for re-review! |
reemhamz
approved these changes
Oct 8, 2024
This was referenced Oct 8, 2024
|
It looks like something went a bit wrong in the rebase of this PR, and several templates that were removed from the code base got added back in again as new files:
Will file a new issue to remove them again |
This was referenced Oct 9, 2024
reemhamz
pushed a commit
that referenced
this pull request
Oct 10, 2024
…14910) * Update analytics documentation, and reflect docs in code Update analytics documentation to remove UA and edit the code to make it match the GA4 docs. - Re-write analytics documentation intro - Remove: UA documentation - Remove: UA dataLayer pushes - Remove: data-link-group (migrate into data-link-position where appropriate) - Remove: data-cta-type="button" - Remove: data-cta-type="link" - data-cta and data-link should not be used on the same attribute * review fixes
craigcook
pushed a commit
that referenced
this pull request
Oct 14, 2024
…14910) * Update analytics documentation, and reflect docs in code Update analytics documentation to remove UA and edit the code to make it match the GA4 docs. - Re-write analytics documentation intro - Remove: UA documentation - Remove: UA dataLayer pushes - Remove: data-link-group (migrate into data-link-position where appropriate) - Remove: data-cta-type="button" - Remove: data-cta-type="link" - data-cta and data-link should not be used on the same attribute * review fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
Update analytics documentation to only reference GA4 and edit the code to make it match the GA4 docs.
Significant changes and points to review
Issue / Bugzilla link
#13951
#14053
#14054
Testing
I know there's a lot of changes but most of them are simple edits. Hopefully this isn't too onerous!