-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Mozilla advertising pages [fix #15198] #15228
Conversation
Marking Do Not Merge because I'm waiting for an updated hero image for the main page, but it should be ready for code review otherwise. |
|
6d5cb58
to
779d532
Compare
779d532
to
41121a5
Compare
The image has been updated, this can merge once it passes code review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a big PR, and you did a very good job with it!
I left some suggestions and fixes that should be quick to patch up.
I'll approve this for now since it needs to go out soon, so feel free to merge after you work on the changes. r+wc
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15228 +/- ##
=======================================
Coverage 77.88% 77.88%
=======================================
Files 163 163
Lines 8480 8480
=======================================
Hits 6605 6605
Misses 1875 1875 ☔ View full report in Codecov by Sentry. |
One-line summary
Updates the /advertising page, now a set of pages with more detailed info on specific products. This is meant to go live by 2 October 2024
Issue / Bugzilla link
#15198
Testing
http://localhost:8000/advertising/
http://localhost:8000/advertising/formats/
http://localhost:8000/advertising/principles/