Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

106 release notes illustrations #12242

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

pascalchevrel
Copy link
Member

@pascalchevrel pascalchevrel commented Oct 14, 2022

PNG optimized with tiny.png, animated GIF optimized with ezgif.com

106 release notes illustrations, go live is October 18.

@stevejalim
Copy link
Collaborator

stevejalim commented Oct 14, 2022

@pascalchevrel Could you rebase your branch on main please? That'll make sure it contains a fixup that will make CI pass again

note to self: why is the difference in circleci/config.yml not showing in the PR diff, I wonder...?

PNG optimized with tiny.png, animated GIF optimized with ezgif.com
@pascalchevrel pascalchevrel force-pushed the 106_release_notes_images branch from 173371f to 32e2677 Compare October 14, 2022 14:36
@pascalchevrel
Copy link
Member Author

@stevejalim should be rebased now

@pmac
Copy link
Member

pmac commented Oct 14, 2022

note to self: why is the difference in circleci/config.yml not showing in the PR diff, I wonder...?

Just not how git works. Merging this would not change that file since Pascal didn't change that file, so it doesn't show in the diff.

@stevejalim
Copy link
Collaborator

@pmac thanks, yeah - the penny dropped a moment ago. There's value in how SteveGit would work ;)

@stevejalim stevejalim merged commit e2a9dd4 into mozilla:main Oct 14, 2022
nathan-barrett pushed a commit that referenced this pull request Oct 14, 2022
PNG optimized with tiny.png, animated GIF optimized with ezgif.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants