Trigger TrackProductDownload for all mobile and desktop downloads #13416

stephaniehobson · 2023-07-17T22:36:08Z

One-line summary

Add Adjust support to TrackProductDownload and trigger on all remaining desktop downloads (previously this had just been triggered on /all).

Significant changes and points to review

add method and link_url parameters to product_download event
- update tests
stop assuming product is firefox and log it if the product is unrecognized
- update tests
add support for App Store links in addition to iTunes links
add logic to support Adjust links
- and identify which product and app store adjust links are for
add TrackProductDownload to all pages on the site and init it
- listen to links with class ga-product-download on all pages
- remove what is now duplicate listener from /all
add class ga-product-download to adjust links and download buttons

Issue / Bugzilla link

#13238

Testing

Successful integration tests

Referrals to the app or play stores should trigger before leaving the site
Buttons/links/dropdowns that refer to /thanks should only trigger on /thanks
Buttons/links/dropdowns that link directly to bouncer should trigger an event when clicked

This branch is up on demo4 for testing with https://tagassistant.google.com/

media/js/base/datalayer-productdownload.es6.js

media/js/base/datalayer-productdownload-init.es6.js

stephaniehobson · 2023-08-17T18:25:11Z

This is ready for review but is toooooo scary to merge before All Hands.

stephaniehobson · 2023-08-30T20:40:05Z

@alexgibson Do you have time to take another look at this?

alexgibson

I went through and tested a bunch of pages locally and everything seems to work well, and nice job on the tests!

I did have a few questions along the way, and I'm not sure if those are really issues or just things I thought I should flag / question.

The one thing I couldn't do is test with tagassistant, which for some reason refuses to connect on any demo server for me :/

media/js/base/datalayer-productdownload.es6.js

bedrock/firefox/templates/firefox/enterprise/index.html

stephaniehobson · 2023-09-05T21:55:18Z

Converting this back to a draft and exploring a different way of doing this.

stephaniehobson · 2023-09-13T22:09:07Z

@alexgibson I made ALL THE UPDATES.

codecov · 2023-09-13T22:14:22Z

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ac82b6b) 76.65% compared to head (4d77bf4) 76.66%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #13416   +/-   ##
=======================================
  Coverage   76.65%   76.66%           
=======================================
  Files         147      147           
  Lines        7878     7881    +3     
=======================================
+ Hits         6039     6042    +3     
  Misses       1839     1839

Files Changed	Coverage Δ
bedrock/mozorg/templatetags/misc.py	`100.00% <100.00%> (ø)`

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

alexgibson

Updates are looking good! I made a couple of comments below. I do wonder if we should apply the query params to the mobile app store links as well? (seems easier to read?)

One other thing that occurred to me is that not all of our adjust links seem to be using the adjust helpers :/

Perhaps if we're to move forward with this approach then we need to make sure we're adding the params to the manual links as well? It's also not 100% clear to me why we stopped using the helpers (perhaps worth asking Dan about?)

alexgibson · 2023-09-14T09:53:25Z

media/js/base/datalayer-productdownload.es6.js

-            productSplit[1] === 'latest' ? 'release' : productSplit[1];
+        let releaseChannel = productSplit[1];
+        // (except for latest, msi, or sub installer - we update those to say release)
+        if (['latest', 'stub', 'msi'].includes(releaseChannel)) {


This might throw an error in IE (haven't tested, but checked https://caniuse.com/array-includes)

alexgibson · 2023-09-14T09:55:07Z

media/js/base/datalayer-productdownload.es6.js

-    } else if (appStoreURL.test(downloadURL)) {
+    } else if (appStoreURL.test(downloadURL) || iTunesURL.test(downloadURL)) {
+        let iosProduct = 'unrecognized';
+        if (downloadURL.indexOf('/id989804926') !== -1) {


Agree it might be worth applying the same params we use on adjust links to make this a bit clearer to read?

10 minutes of exploration tells me this could be complicated because the store links are often included in the adjust links. Can I add this to my list of future improvements and merge this as is? (once I fix the IE compatibility problem)

alexgibson

r+

stephaniehobson force-pushed the pd_adjust branch 5 times, most recently from 8663c90 to 5b44ecb Compare July 20, 2023 19:54

stephaniehobson mentioned this pull request Jul 20, 2023

Track Firefox downloads from /thanks in GA4 #13415

Closed

alexgibson reviewed Jul 21, 2023

View reviewed changes

media/js/base/datalayer-productdownload.es6.js Outdated Show resolved Hide resolved

stephaniehobson force-pushed the pd_adjust branch from 5b44ecb to 106c30f Compare July 21, 2023 18:25

stephaniehobson force-pushed the pd_adjust branch from b4fe423 to 40f906e Compare August 16, 2023 22:51

stephaniehobson changed the title ~~Add Adjust support to TrackProductDownload~~ Update TrackProductDownload for Adjust and /thanks pages Aug 17, 2023

stephaniehobson commented Aug 17, 2023

View reviewed changes

media/js/base/datalayer-productdownload-init.es6.js Show resolved Hide resolved

stephaniehobson force-pushed the pd_adjust branch from d09117b to 66e9d56 Compare August 17, 2023 02:51

stephaniehobson changed the title ~~Update TrackProductDownload for Adjust and /thanks pages~~ Trigger TrackProductDownload for all mobile and desktop downloads Aug 17, 2023

stephaniehobson added P1 First level priority - Must have Needs Review Awaiting code review Review: M Code review time: 1-2 hours Analytics 📈 labels Aug 17, 2023

stephaniehobson force-pushed the pd_adjust branch from 66e9d56 to 0d280c8 Compare August 17, 2023 02:55

stephaniehobson marked this pull request as ready for review August 17, 2023 18:25

stephaniehobson added the Do Not Merge ⚠️ label Aug 17, 2023

stephaniehobson removed the Do Not Merge ⚠️ label Aug 28, 2023

alexgibson reviewed Aug 31, 2023

View reviewed changes

stephaniehobson marked this pull request as draft September 5, 2023 21:54

stephaniehobson added 4 commits September 12, 2023 15:04

Add Adjust support to product_download

9a61871

Track Firefox downloads from /thanks in GA4

d5d2a87

review fix

cc08e05

Remove linkURL from product download event tracking

c9d4bc4

stephaniehobson added 2 commits September 12, 2023 19:42

account for market:// links to PlayStore

497f23c

switch to indexOf for adjust tests

2c14f3c

stephaniehobson force-pushed the pd_adjust branch from 0d280c8 to 2b1c77f Compare September 13, 2023 03:01

tweak how msi is tracked

c8ebc7a

stephaniehobson force-pushed the pd_adjust branch from 2b1c77f to c8ebc7a Compare September 13, 2023 18:26

track adjust with query params

4f1b967

stephaniehobson marked this pull request as ready for review September 13, 2023 22:09

alexgibson reviewed Sep 14, 2023

View reviewed changes

review fix

4d77bf4

alexgibson approved these changes Sep 15, 2023

View reviewed changes

stephaniehobson merged commit 1a18ca5 into main Sep 15, 2023
5 checks passed

stephaniehobson deleted the pd_adjust branch September 15, 2023 15:31

stephaniehobson mentioned this pull request Nov 30, 2023

Epic: Add support for GA4 #13238

Closed

stephaniehobson removed the Needs Review Awaiting code review label Nov 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Trigger TrackProductDownload for all mobile and desktop downloads #13416

Trigger TrackProductDownload for all mobile and desktop downloads #13416

stephaniehobson commented Jul 17, 2023 •

edited

Loading

stephaniehobson commented Aug 17, 2023

stephaniehobson commented Aug 30, 2023

alexgibson left a comment

stephaniehobson commented Sep 5, 2023

stephaniehobson commented Sep 13, 2023

codecov bot commented Sep 13, 2023 •

edited

Loading

alexgibson left a comment •

edited

Loading

alexgibson Sep 14, 2023

alexgibson Sep 14, 2023

stephaniehobson Sep 14, 2023

alexgibson left a comment

Trigger TrackProductDownload for all mobile and desktop downloads #13416

Trigger TrackProductDownload for all mobile and desktop downloads #13416

Conversation

stephaniehobson commented Jul 17, 2023 • edited Loading

One-line summary

Significant changes and points to review

Issue / Bugzilla link

Testing

stephaniehobson commented Aug 17, 2023

stephaniehobson commented Aug 30, 2023

alexgibson left a comment

Choose a reason for hiding this comment

stephaniehobson commented Sep 5, 2023

stephaniehobson commented Sep 13, 2023

codecov bot commented Sep 13, 2023 • edited Loading

Codecov Report

alexgibson left a comment • edited Loading

Choose a reason for hiding this comment

alexgibson Sep 14, 2023

Choose a reason for hiding this comment

alexgibson Sep 14, 2023

Choose a reason for hiding this comment

stephaniehobson Sep 14, 2023

Choose a reason for hiding this comment

alexgibson left a comment

Choose a reason for hiding this comment

stephaniehobson commented Jul 17, 2023 •

edited

Loading

codecov bot commented Sep 13, 2023 •

edited

Loading

alexgibson left a comment •

edited

Loading