Track conversions in GA4 for when Firefox is set to default browser #13238 #13913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13913 +/- ##
==========================================
+ Coverage 76.72% 76.98% +0.26%
==========================================
Files 145 145
Lines 8008 7835 -173
==========================================
- Hits 6144 6032 -112
+ Misses 1864 1803 -61 ☔ View full report in Codecov by Sentry. |
stephaniehobson
force-pushed
the
ga_set
branch
2 times, most recently
from
2b4c043 to
01e17fe
Compare
- Set the custom user dimensions indicating if Firefox is default. - Send the conversion event - Docs - Fix a bug in WNP118 where dimension was set twice
stephaniehobson
force-pushed
the
ga_set
branch
from
01e17fe to
ff186fa
Compare
stephaniehobson
added
P1
alexgibson
approved these changes
Nov 21, 2023
docs/attribution/0001-analytics.rst
Outdated
|
|
||
| window.dataLayer.push({ | ||
| event: 'dimension_set', | ||
| firefox_isDefault: true |
There was a problem hiding this comment.
Nit: this is an odd mix of both snake_case and camelCase, is that something GA prescribes? I wondered if we could just stick to one (probably snake_case as that's what is used elsewhere mostly)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
Track conversions in GA4 for when Firefox is set to default browser.
Significant changes and points to review
default_browser_setanddimension_setIssue / Bugzilla link
#13238
Testing
Local testing can be done to make sure the dataLayer has the expected data:
http://localhost:8000/en-GB/firefox/118.0/whatsnew/
http://localhost:8000/en-GB/firefox/116.0/whatsnew/
http://localhost:8000/en-US/firefox/set-as-default/thanks/