Documentation correction #13928
Closed
Documentation correction #13928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephaniehobson
added
Needs Review
alexgibson
approved these changes
Nov 24, 2023
| +-----------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | ||
| | ``data-cta-position`` | Location of CTA on the page (e.g. ``primary``, ``secondary``, ``header``) | | ||
| +-----------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | ||
|
|
||
|
|
||
| **Old data-cta structure** |
There was a problem hiding this comment.
I'm a little confused here, since does seem to be talking about an older data-cta pattern that exists (see doc example below your changes).
It looks like data-link-type and data-link-name are even older maybe? Perhaps we should just list all of the outdated / obsolete attributes together?
data-cta-name(when used together withdata-cta-type, which still exists)data-link-typedata-link-name
There was a problem hiding this comment.
I think I'm confused too. These data-attributes are a bit of a mess.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
Correct documentation for cta links.
Significant changes and points to review
Grouped the 2 tables with a focus on
data-cta-type. Corrected the attributes that trigger the old data structure.Issue / Bugzilla link
#13238
Testing
make livedocs