Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cdn videos to report-only CSP media-src #15550

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

janbrasna
Copy link
Contributor

@janbrasna janbrasna commented Nov 22, 2024

One-line summary

Follows up from #15548 adding an older host used for serving videos in the past to add to media-src policy recently added to take precedence over default-src wildcard fallbacks.

Significant changes and points to review

This is a new addition, so instead of allowing all the default hosts we're trying to explicitly define the sources (and/or paths if needed) to have an exhaustive list of known media hosts being used around the site.

Issue / Bugzilla link

#15546

Testing

curl -I http://localhost:8000/de/

@janbrasna janbrasna requested a review from a team as a code owner November 22, 2024 17:22
Copy link
Member

@robhudson robhudson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎥

@robhudson robhudson merged commit 52c991c into mozilla:main Nov 22, 2024
3 checks passed
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.92%. Comparing base (f8d81da) to head (4bf4057).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15550   +/-   ##
=======================================
  Coverage   78.92%   78.92%           
=======================================
  Files         158      158           
  Lines        8279     8279           
=======================================
  Hits         6534     6534           
  Misses       1745     1745           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@janbrasna janbrasna deleted the add/csp-report-media branch November 22, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants