Refresh: Fix nav sticky scrolling styling/condition #15673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janbrasna
commented
Dec 4, 2024
| // add styling for when scrolling the viewport | ||
| if (window.scrollY > 0) { | ||
| // add styling for when scrolling the viewport and nav is already sticking | ||
| if (window.scrollY > 0 && _navElem.getBoundingClientRect().top == 0) { |
There was a problem hiding this comment.
E.g. I'd add some position tolerance instead of hard y===0, given the potential subpixel precision of this or some "rubberband" overscroll etc:
Suggested change
| if (window.scrollY > 0 && _navElem.getBoundingClientRect().top == 0) { | |
| if (window.scrollY > 0 && _navElem.getBoundingClientRect().top < 1) { |
There was a problem hiding this comment.
I have been considering Intersection Observers but that felt like needing a little different approach for most of the MzpNavigation.*Sticky logic, so this was to minimize the change surface. Observer API would be a better approach generally, so if this feels wonky at times that might be the next iteration.
stephaniehobson
added
Needs Review
stephaniehobson
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
Only applies "scrolling" or "sticky" decoration once the navbar actually settles in its sticky position.
Significant changes and points to review
Not sure if this is the least fragile approach, but felt like the most obvious one.
Be skeptical, please. Would love to learn any better and simpler way!
Issue / Bugzilla link
Fixes #15619
Testing
Yes, please. Things like pinch zooming, scrolling or dragging beyond the viewport, checking any motion a11y preference is still being honored etc.