Use only base protocol social icons #15676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janbrasna
force-pushed
the
upd/footer-social-icons
branch
from
e79c004 to
180298c
Compare
janbrasna
force-pushed
the
upd/footer-social-icons
branch
from
180298c to
b971f86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
Apply opacity between states instead of separate icons.
Significant changes and points to review
Speeds up the hover effect by not loading assets not preloaded yet, avoiding flash of blank space.
NB: the opacity doesn't produce the exact color (
#828282130,130,130), the 45% alpha results in#7F7F7F(127,127,127) for me, if that's acceptable.Issue / Bugzilla link
#15654 (comment) (also should help mitigate #15644…)
Testing
The best is to actually start at https://www-demo4.allizom.org/en-US/ that is "reasonably slow" and disabling caches (and/or setting some throttling in devtools, e.g. 3G) — and trying the hovers there first. This PR will have none of that delay by design.