Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Accessibility issues on contact page #15695

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Fix: Accessibility issues on contact page #15695

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81d4a57
Update heading levels to maintain semantic order
camillegonzales Dec 6, 2024
20bf00d
Remove role=navigation and add <nav> wrapper
camillegonzales Dec 6, 2024
b6ce35c
Added aria-label to navigation
camillegonzales Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions bedrock/mozorg/templates/mozorg/contact/contact-landing.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ <h2>Contacting Mozilla</h2>

<div class="contact-sections">
<div class="contact-section">
<h4>Find us online</h4>
<h3>Find us online</h3>
<ul class="mzp-u-list-styled">
<li><a href="https://facebook.com/mozilla" hreflang="en-US" rel="external">Facebook</a></li>
<li><a href="{{ mozilla_twitter_url() }}" rel="external">X (formerly Twitter)</a></li>
Expand All @@ -53,7 +53,7 @@ <h4>Find us online</h4>
</div>

<div class="contact-section">
<h4>Join us</h4>
<h3>Join us</h3>
<ul class="mzp-u-list-styled">
<li><a href="{{ url('mozorg.contribute') }}">Get involved</a></li>
<li><a href="{{ url('careers.home') }}">Career opportunities</a></li>
Expand All @@ -62,7 +62,7 @@ <h4>Join us</h4>
</div>

<div class="contact-section">
<h4>Questions &amp; feedback</h4>
<h3>Questions &amp; feedback</h3>
<ul class="mzp-u-list-styled">
<li><a href="https://support.mozilla.org/">Get support</a></li>
<li><a href="{{ url('foundation.licensing') }}">Browser distribution &amp; licensing</a></li>
Expand Down
24 changes: 13 additions & 11 deletions bedrock/mozorg/templates/mozorg/contact/includes/tab-nav.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,16 @@
file, You can obtain one at https://mozilla.org/MPL/2.0/.
#}

<ul class="category-tabs" role="navigation">
<li {% if current == 'contact' %}class="current"{% endif %} data-id="contact">
<a href="{{ url('mozorg.contact.contact-landing') }}">Contact us</a>
</li>
<li {% if current == 'spaces' %}class="current"{% endif %} data-id="spaces">
<a href="{{ url('mozorg.contact.spaces.spaces-landing') }}">Spaces</a>
</li>
<li data-id="communities">
<a href="https://community.mozilla.org/groups/">Communities</a>
</li>
</ul>
<nav>
camillegonzales marked this conversation as resolved.
Show resolved Hide resolved
<ul class="category-tabs">
<li {% if current == 'contact' %}class="current"{% endif %} data-id="contact">
<a href="{{ url('mozorg.contact.contact-landing') }}">Contact us</a>
</li>
<li {% if current == 'spaces' %}class="current"{% endif %} data-id="spaces">
<a href="{{ url('mozorg.contact.spaces.spaces-landing') }}">Spaces</a>
</li>
<li data-id="communities">
<a href="https://community.mozilla.org/groups/">Communities</a>
</li>
</ul>
</nav>
Loading