Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent product name for 'Firefox Translations' in Fluent (Fixes #15442) #15769

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

stephaniehobson
Copy link
Contributor

@stephaniehobson stephaniehobson commented Dec 17, 2024

One-line summary

Treat "Firefox Translations" as a single product name in Fluent strings.

Significant changes and points to review

  • This is the contents of Use consistent product name for 'Firefox Translations' in Fluent (Fixes #15442) #15459 with the addition of some versioning
  • Updated instances of { -brand-name-firefox } Translations to { -brand-name-firefox-translations } in relevant files.
  • Ensured consistency by using the pre-defined { -brand-name-firefox-translations } entry from brands.ftl across all strings.
  • Verified that the changes align with the Fluent localization standards for product naming.

Issue / Bugzilla link

Resolves Issue #15442

Testing

  • Manually checked that each modified string renders "Firefox Translations" as a single entity in the UI.
  • Confirmed the updated strings in different localization scenarios to ensure they display correctly.

@stephaniehobson stephaniehobson requested a review from a team as a code owner December 17, 2024 23:59
@stephaniehobson stephaniehobson changed the title Translate v2 Use consistent product name for 'Firefox Translations' in Fluent (Fixes #15442) Dec 17, 2024
@stephaniehobson stephaniehobson added L10N Needs Review Awaiting code review Review: XS Code review time: up to 30min labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L10N Needs Review Awaiting code review Review: XS Code review time: up to 30min
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Firefox Translations" should be coded together as a product name in Fluent
2 participants