-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List breaches #2917
Merged
Merged
List breaches #2917
Changes from 28 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
84a4f62
WIP
rhelmer 5f2bda2
Clear search on reload, turn off autocomplete, remove debugging
rhelmer 7a128ab
format dates
rhelmer 9d436bd
remove security tips per requirements
rhelmer a2e1d0c
no need to modify the older client code
rhelmer ec27adc
these pages do not use auth and do not need nonce
rhelmer 89beb67
port the icons and recommendation sorter from pre-refresh version
rhelmer b371194
remove all inline style
rhelmer c1ae307
join properly
rhelmer 9222ea9
simplify style
rhelmer 3d6d120
show CTAs correctly
rhelmer bde6e64
recommendations may not be present
rhelmer feb5785
rebase to main and switch to new guestLayout
rhelmer f236864
Some styling for the breach overview page
Vinnl 587a62f
fixup! WIP
Vinnl 5f5d6b1
Some styling for the breach detail page
Vinnl c23f72a
Link to the breaches overview
Vinnl 6451c7e
fixup! WIP
Vinnl 3992e32
fixup! Some styling for the breach overview page
Vinnl 38c9c32
fixup! Link to the breaches overview
Vinnl 818dd6b
fixup! fixup! Link to the breaches overview
Vinnl b247e4c
Move JS for allBreachesPartial into partials dir
Vinnl ef4802a
Only run allBreachesPartial JS on the correct page
Vinnl 086ec77
Remove unnecessary DOMContentLoaded listener
Vinnl 754522a
Remove mistakenly-removed header key
Vinnl a7f402f
Lazily load breach logos
Vinnl 068b0e7
Move some V2 strings into V2 section
Vinnl 9149545
Update some strings as per Content
Vinnl 7ccc4ac
fixup! Update some strings as per Content
Vinnl 2883ece
Update src/utils/recommendations.js
toufali 4c886b2
Merge branch 'MNTOR-1343-breach-page-styling' of https://github.com/m…
rhelmer a2654e9
jsdoc type object for breach
rhelmer f1bdd6d
remove header link and fix broken user menu
toufali ffdcec9
conform to partial naming convention
toufali ae28dac
remove obsolete string
toufali 72bf369
make "All Breaches" footer link title-case
toufali a07fafa
add "All Breaches" link to main layout footer
toufali e2dc855
remove 404 links to Security Tips
toufali 66fba1a
add/update utm to Breach Detail relay/vpn links
toufali 0fb5915
fix search and avoid page reload on enter keypress
toufali File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why same string twice? Would the header and footer ever need to be translated differently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As is often the resolution between the 3 of us, let's just remove the header link altogether and pretend this never happened?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update: I removed the header link per UX, so this is non-issue. f1bdd6d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a recommendation from the l10n team (or at least Peiying) to not re-use strings. It's hardly an issue for localisers, since Pontoon will suggest the same translation, but different contexts might lead to different translations (or e.g. just changes in capitalisation) in some locales, so using different strings accommodates that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Footer/Header is an edge case, but in general it's better to have different strings for different contexts.