Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List breaches #2917

Merged
merged 40 commits into from
Mar 24, 2023
Merged
Show file tree
Hide file tree
Changes from 28 commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
84a4f62
WIP
rhelmer Mar 9, 2023
5f2bda2
Clear search on reload, turn off autocomplete, remove debugging
rhelmer Mar 9, 2023
7a128ab
format dates
rhelmer Mar 9, 2023
9d436bd
remove security tips per requirements
rhelmer Mar 9, 2023
a2e1d0c
no need to modify the older client code
rhelmer Mar 9, 2023
ec27adc
these pages do not use auth and do not need nonce
rhelmer Mar 9, 2023
89beb67
port the icons and recommendation sorter from pre-refresh version
rhelmer Mar 15, 2023
b371194
remove all inline style
rhelmer Mar 15, 2023
c1ae307
join properly
rhelmer Mar 15, 2023
9222ea9
simplify style
rhelmer Mar 15, 2023
3d6d120
show CTAs correctly
rhelmer Mar 15, 2023
bde6e64
recommendations may not be present
rhelmer Mar 16, 2023
feb5785
rebase to main and switch to new guestLayout
rhelmer Mar 16, 2023
f236864
Some styling for the breach overview page
Vinnl Mar 16, 2023
587a62f
fixup! WIP
Vinnl Mar 16, 2023
5f5d6b1
Some styling for the breach detail page
Vinnl Mar 22, 2023
c23f72a
Link to the breaches overview
Vinnl Mar 22, 2023
6451c7e
fixup! WIP
Vinnl Mar 22, 2023
3992e32
fixup! Some styling for the breach overview page
Vinnl Mar 22, 2023
38c9c32
fixup! Link to the breaches overview
Vinnl Mar 23, 2023
818dd6b
fixup! fixup! Link to the breaches overview
Vinnl Mar 23, 2023
b247e4c
Move JS for allBreachesPartial into partials dir
Vinnl Mar 23, 2023
ef4802a
Only run allBreachesPartial JS on the correct page
Vinnl Mar 23, 2023
086ec77
Remove unnecessary DOMContentLoaded listener
Vinnl Mar 23, 2023
754522a
Remove mistakenly-removed header key
Vinnl Mar 23, 2023
a7f402f
Lazily load breach logos
Vinnl Mar 23, 2023
068b0e7
Move some V2 strings into V2 section
Vinnl Mar 23, 2023
9149545
Update some strings as per Content
Vinnl Mar 23, 2023
7ccc4ac
fixup! Update some strings as per Content
Vinnl Mar 23, 2023
2883ece
Update src/utils/recommendations.js
toufali Mar 24, 2023
4c886b2
Merge branch 'MNTOR-1343-breach-page-styling' of https://github.com/m…
rhelmer Mar 24, 2023
a2654e9
jsdoc type object for breach
rhelmer Mar 24, 2023
f1bdd6d
remove header link and fix broken user menu
toufali Mar 24, 2023
ffdcec9
conform to partial naming convention
toufali Mar 24, 2023
ae28dac
remove obsolete string
toufali Mar 24, 2023
72bf369
make "All Breaches" footer link title-case
toufali Mar 24, 2023
a07fafa
add "All Breaches" link to main layout footer
toufali Mar 24, 2023
e2dc855
remove 404 links to Security Tips
toufali Mar 24, 2023
66fba1a
add/update utm to Breach Detail relay/vpn links
toufali Mar 24, 2023
0fb5915
fix search and avoid page reload on enter keypress
toufali Mar 24, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions locales/en/app.ftl
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,6 @@ preferences = Preferences
# Link title
home = Home

# Link title
breaches = Breaches

# Link title
security-tips = Security Tips

Expand Down Expand Up @@ -375,7 +372,6 @@ account-not-required = { -brand-name } browser not required for a { -brand-fxa }
## $breachName (String) - Number of the breach

was-your-info-exposed = Was your info exposed in the { $breachName } data breach?
find-out-if = Find out if your data was exposed in this breach.

fb-not-comp = This email did not appear in the { $breachName } breach.

Expand All @@ -400,8 +396,6 @@ fb-comp-and-others =
no-other-breaches-found = No other breaches found from a basic search.

no-results-blurb = Sorry, that breach is not in our database.
all-breaches-headline = All breaches in { -product-name }
search-breaches = Search Breaches

# This string contains nested markup that is later used to style and link the text inside of it.
# Please do not modify or remove "<a>", "</a>", "<span>" and "</span>".
Expand Down Expand Up @@ -880,6 +874,8 @@ meta-desc = Find out if you’ve been part of a data breach with { -brand-fx-mon

brand-fx-monitor = { -brand-fx-monitor }
sign-in = Sign In
header-nav-all-breaches = All breaches
footer-nav-all-breaches = All breaches
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why same string twice? Would the header and footer ever need to be translated differently?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As is often the resolution between the 3 of us, let's just remove the header link altogether and pretend this never happened?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: I removed the header link per UX, so this is non-issue. f1bdd6d

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a recommendation from the l10n team (or at least Peiying) to not re-use strings. It's hardly an issue for localisers, since Pontoon will suggest the same translation, but different contexts might lead to different translations (or e.g. just changes in capitalisation) in some locales, so using different strings accommodates that.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Footer/Header is an edge case, but in general it's better to have different strings for different contexts.


## Site navigation

Expand Down Expand Up @@ -914,3 +910,19 @@ error-page-error-404-cta-button = Go back
# $errorCode (number) - the status code of the error, e.g. 403
error-page-error-other-title = { $errorCode } Something went wrong
error-page-error-other-copy = Please try again or come back later

## Breach overview page

all-breaches-headline-2 = All breaches detected by { -brand-fx-monitor }
all-breaches-lead = We monitor all known data breaches to find out if your personal information was compromised. Here’s a complete list of all of the breaches that have been reported since 2007.
search-breaches = Search Breaches

# the kind of user data exposed to hackers in data breach.
exposed-data = Exposed data:

## Public breach detail page

find-out-if-2 = Find out if you were involved in this breach
find-out-if-description = We’ll help you quickly see if your email address was exposed in this breach, and understand what to do next.

breach-detail-cta-signup = Check for breaches
27 changes: 9 additions & 18 deletions locales/en/recommendations.ftl
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ rec-ssn =
rec-pw-1-subhead = Change your password
# Link title
rec-pw-1-cta = Change password for this site
rec-pw-1 =
Make this password unique and different from any others you use.
A good strategy to follow is to combine two or more unrelated
words to create an entire passphrase.
rec-pw-1-2 =
Make this password unique and different from any others you use.
A good strategy to follow is to combine two or more unrelated
words to create an entire pass phrase, and include numbers and symbols.

# Recommendation subhead
rec-pw-2-subhead = Update other logins using the same password
Expand Down Expand Up @@ -66,23 +66,14 @@ rec-email =
hides your real email address while forwarding emails to your real inbox.

# Recommendation subhead
rec-ip-subhead = Use a service that masks your IP address
# Link title
rec-ip-us-cta = Try { -brand-fpn }
rec-ip-us =
Your Internet Protocol address (IP address) pinpoints your location
and internet service provider. A service like { -brand-fpn }
masks your IP address to hide your location.
rec-ip-non-us =
Your Internet Protocol address (IP address) pinpoints your location
and internet service provider. With a virtual private network (VPN), you can hide your location
and mask your IP address.
rec-ip-subhead-2 = Use a VPN to mask your IP address

# Recommendation subhead
rec-moz-vpn-cta = Try { -brand-mozilla-vpn }
rec-moz-vpn-update =
Your Internet Protocol address (IP address) can reveal your location and internet service provider. A service
like { -brand-mozilla-vpn } hides your IP address and location for your entire device.
rec-moz-vpn-update-2 =
Your Internet Protocol address (IP address) pinpoints your location
and internet service provider. A service like { -brand-mozilla-vpn }
masks your IP address to hide your location.

rec-hist-pw-subhead = Avoid reusing passwords
# Link title
Expand Down
168 changes: 0 additions & 168 deletions public/js/all-breaches.js

This file was deleted.

3 changes: 2 additions & 1 deletion src/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,8 @@ app.use(
)

const imgSrc = [
"'self'"
"'self'",
'https://monitor.cdn.mozilla.net'
]

if (AppConstants.FXA_ENABLED) {
Expand Down
19 changes: 19 additions & 0 deletions src/client/css/global.css
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,25 @@ body > header .nav-wrapper {
gap: var(--padding-sm);
}

body > header menu {
display: flex;
gap: var(--gap);
align-items: center;
}

body > header menu a {
color: var(--blue-50);
text-decoration: none;
}

body > header menu a:hover {
text-decoration: underline;
}

.mobile body > header menu a:not(.button) {
display: none;
}

main {
--max-width-margin: calc(50% - var(--max-width)/2);

Expand Down
Loading