Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNTOR-3815: call for scan results with broker under maintenance #5322

Merged
merged 8 commits into from
Nov 20, 2024
Merged

MNTOR-3815: call for scan results with broker under maintenance #5322

merged 8 commits into from
Nov 20, 2024

Conversation

mansaj
Copy link
Collaborator

@mansaj mansaj commented Nov 18, 2024 •
edited
Loading

References:

Jira: MNTOR-3815

Description

A new function getScanResultsWithBrokerUnderMaintenance that joins the two tables:

  • scan results
  • data_brokers

and keep only results where

  • data broker has removal_under_maintenance status
  • scan result is > 200 days old

How to test

Visiting this url: http://localhost:6060/user/dashboard/fix/data-broker-profiles/removal-under-maintenance

Checklist (Definition of Done)

  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

@github-actions GitHub Actions
Copy link

Preview URL 🚀 : https://blurts-server-pr-5322-mgjlpikfea-uk.a.run.app

@github-actions GitHub Actions
Copy link

Preview URL 🚀 : https://blurts-server-pr-5322-mgjlpikfea-uk.a.run.app

@mansaj mansaj marked this pull request as ready for review November 20, 2024 17:03
rhelmer
rhelmer approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@rhelmer rhelmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm overall, I made a few suggestions but nothing blocking.

...ated)/user/(dashboard)/dashboard/fix/data-broker-profiles/removal-under-maintenance/page.tsx Outdated Show resolved Hide resolved
src/db/tables/onerep_scans.ts Show resolved Hide resolved
src/db/tables/onerep_scans.ts Outdated Show resolved Hide resolved
src/db/tables/onerep_scans.ts Outdated Show resolved Hide resolved
src/db/tables/onerep_scans.ts Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Preview URL 🚀 : https://blurts-server-pr-5322-mgjlpikfea-uk.a.run.app

@mansaj mansaj merged commit 54a859d into mntor-3378 Nov 20, 2024
7 checks passed
@mansaj mansaj deleted the MNTOR-3815 branch November 20, 2024 21:00
@github-actions GitHub Actions
Copy link

Cleanup completed - database 'blurts-server-pr-5322' destroyed, cloud run service 'blurts-server-pr-5322' destroyed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codemist codemist codemist approved these changes

@rhelmer rhelmer rhelmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mansaj @rhelmer @codemist