Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ci #337

Merged
merged 3 commits into from
Oct 5, 2022
Merged

fix ci #337

merged 3 commits into from
Oct 5, 2022

Conversation

bholley
Copy link
Collaborator

@bholley bholley commented Oct 4, 2022

  • Switch CI test run to --all-targets.
  • Update snapshots for cargo vet aggregate.
  • Fix clippy warning from new Rust release.

@bholley
Switch CI test run to --all-targets.
cd5a1c8 
Currently we're not running integration tests in CI, so things like
test_cli are currently failing.

This new flag appears (confusingly) to run all tests except doc tests,
whereas bare cargo test also runs doc tests. Given that we have a
separate job for doc tests already, this seems to be what we want.
@bholley
Update snapshots for cargo vet aggregate.
9fb1f00
@bholley
Fix clippy warning from new Rust release.
a2b9ffb
@bholley bholley requested a review from mystor October 4, 2022 20:24
@bholley
Copy link
Collaborator Author

bholley commented Oct 4, 2022

r? @mystor

@bholley bholley merged commit 7257bfc into main Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mystor mystor mystor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bholley @mystor