Support specifying version for macro expansion. #928
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: [mozilla#900]. Previously, cbindgen might sometimes match the wrong version of a crate if the crate occurs multiple times in the dependency list produced by `cargo metadata`. This meant that you'd observe transient errors where _sometimes_ the right output would be produced (when the intended version is macro-expanded), and sometimes it would not (when the wrong version is macro-expanded). This commit modifies the configuration to permit optionally specifying name and version separately instead of solely specifying version. This is an initial draft, as I have not yet been able to test it. [mozilla#900]: mozilla#900 Signed-off-by: Andrew Lilley Brinker <alilleybrinker@gmail.com>
alilleybrinker
changed the title
alilleybrinker
changed the title
|
Some quick testing of mine showed that on initial run this patch did appear to cause just the correct version to be selected, but for some reason if run again it resulted in failure. I haven't yet been able to debug why that is. Suffice to say, this patch is not yet a sufficient solution. |
|
I'm actually going to close this out. I figured out a way to work around this issue for my own use case, and it doesn't make sense to further pursue work on this patch. The patch doesn't currently work. That said, if someone else wants to take this and do something with it, feel free! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #900.
Previously, cbindgen might sometimes match the wrong version of a crate
if the crate occurs multiple times in the dependency list produced by
cargo metadata. This meant that you'd observe transient errors wheresometimes the right output would be produced (when the intended
version is macro-expanded), and sometimes it would not (when the wrong
version is macro-expanded).
This commit modifies the configuration to permit optionally specifying
name and version separately instead of solely specifying version.
This is an initial draft, as I have not yet been able to test it.
Signed-off-by: Andrew Lilley Brinker alilleybrinker@gmail.com